203909 - Behavior of built-in functions called as constructors should follow standard.

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Igor Bukanov]

This is a Rhino version of bug 202019 , see the description there.

Comment 1

[Igor Bukanov]

Attachment: Fix: throw TypeError by default in IdFunction.constructor if the function is not explicitly coded as constructor.

To resolve this in a uniform way I changed BaseFunction.constructor to always
call createObject and then run the call method so IdFunction and FunctionObject
needs to override only createObject and not the construct method itself. Then
IdFunction.createObject simply throws TypeError if the function is not
explicitly marked as constructor.

The current behavior of SM can be obtained if instead of throwing error,
IdFunction.createObject can call super.createObject.

The patch should cover all the standard library functions since all of them are
implemented in terms of IdFunction and they marked as constructors only when
the standard required it.

Comment 2

[Igor Bukanov]

Attachment: Fix update: better comments

Comment 3

[Igor Bukanov]

I committed the fix, now in Rhino shell:

js> new parseInt('1')
js: "<stdin>", line 1: uncaught JavaScript exception: TypeError: "parseInt" is
not a constructor. (<stdin>; line 1)

js> new String.prototype.toString()
js: "<stdin>", line 2: uncaught JavaScript exception: TypeError: "toString" is
not a constructor. (<stdin>; line 2)

Comment 4

[Phil Schwartau]

Verified FIXED. But is the error message for |eval| correct?

Rhino 1.5 release 5 0000 00 00
js> var obj = new eval();
TypeError: [object global] is not a function.


Shouldn't the error message say, '"eval" is not a constructor'?


COMPARE: 

js> var obj = new isFinite();
TypeError: "isFinite" is not a constructor.

js> var obj = new Date.parse();
TypeError: "parse" is not a constructor.

Comment 5

[Phil Schwartau]

Note: Igor has fixed the error message for |new eval();| in bug 204210.
See bug 204210 comment 4.

Comment 6

[Igor Bukanov]

Targeting as resolved against 1.5R5