203956 - Mac static build is broken

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

ssu's checkin for bug 125106 broke the Mac static build.  Here's the error:

c++  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align
-Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-long-long
-fpascal-strings -traditional-cpp -fno-common -fshort-wchar
-I/Developer/Headers/FlatCarbon -F/System/Library/Frameworks -pipe  -DNDEBUG
-DTRIMMED -O -fPIC -arch ppc -o libxpinstall.dylib  CertReader.o nsInstall.o
nsInstallTrigger.o nsInstallVersion.o nsInstallFolder.o nsJSInstall.o nsJSFile.o
nsJSInstallTriggerGlobal.o nsJSInstallVersion.o nsSoftwareUpdate.o
nsSoftwareUpdateRun.o nsInstallFile.o nsInstallExecute.o nsInstallPatch.o
nsInstallUninstall.o nsInstallResources.o nsRegisterItem.o
nsTopProgressNotifier.o nsLoggingProgressNotifier.o ScheduledTasks.o
nsXPIProxy.o nsXPITriggerInfo.o nsXPInstallManager.o nsInstallFileOpItem.o
nsJSFileSpecObj.o nsInstallLogComment.o nsInstallBitwise.o      
-L../../dist/bin -L../../dist/lib  -L../../dist/bin -lmozjs -L../../dist/bin
-lxpcom -L../../dist/bin -L/builds/tinderbox/SeaMonkey/Darwin_!
 6.5_Depend/
mozilla/dist/lib -lplds4 -lplc4 -lnspr4 -lpthread  -L../../dist/lib
-lxpcom_compat ../../dist/lib/libunicharutil_s.a -lz   -framework Carbon
/System/Library/Frameworks/Carbon.framework/Carbon  -bundle -lm    
ld: ../../dist/lib/libunicharutil_s.a(nsUnicharUtils.o) has local relocation
entries in non-writable section (__TEXT,__text)
make[4]: *** [libxpinstall.dylib] Error 1

The problem is that libunicharutil_s.a has been built with non-position
independent code.  But xpinstall is forced to be a shared library, so it needs
to use PIC if xpinstall is enabled.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 122129 [details] [diff] [review]
patch

xpinstall isn't the only forced shared lib that uses unicharutil.  inspector
uses it as do the meta components.  Not sure why this is just becoming a
problem though.

Comment 3

[Brian Ryner (not reading)]

Probably because we don't build inspector for Camino so that bustage never
showed up.  Sounds like we should make unicharutil_s use PIC unconditionally.

Comment 4

[Brian Ryner (not reading)]

Attachment: patch #2

how about this?

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 122179 [details] [diff] [review]
patch #2

a=sspitzer

Comment 6

[Brian Ryner (not reading)]

checked in.