203992 - Bookmark's Notify/schedule fail to prompt user when change has occured

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Chris Petersen]

Build: 2003-04-28-03
Platform: All
Expected Results: After specifying a time schedule and notification method for a
bookmark,the application should prompt user when a change occurs.
What I got: No notification is occurs when page is updated.

Steps to reproduce:

1) Bookmark a news site that recieves frequent updates like www.cnn.com
2) Go to Manage bookmarks and select this bookmark. Press Properties.
3) Click on the schedule tab. Select everyday - from: midnight to: 11 pm. Every
2 minutes.
4) Click on Notify tab. Enable all notifications. Click OK.
5) Go to another site that isn't the bookmarked site.
6) The notification doesn't occur.

Comment 1

[Jan Varga [:janv]]

-> me

Comment 2

[Paolo Cascini]

I get exactly the opposite behaviour. 
To test it, I have tried first with www.cnn.com and i got a notification every
single minute.
Then I have also tried it with websites like www.openzaurus.org that are not
updates very often. Still i get a notify every single minute.

Comment 3

[Paolo Cascini]

maybe it is a duplicate of 199257?

Comment 4

[Paolo Cascini]

I have installed mozilla 1.4a (build ID: 2003040105). 
The notify option seems not to work anymore.
What I have noticed though, is that in version 1.3 it worked except for the
change of icon (sometimes it worked too often).
In version 1.4a the change of icon occurs only to the bookmarks that were
selected by version 1.3 (meaning that it doesn't know which website has changed
but it remember what vesion 1.3 knew). 

Comment 5

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 6

[Michael Baffoni]

The popup notification stopped working totally for me.  My bookmark is set to go
to http://www.mcafeeb2b.com/naicommon/download/dats/find.asp which is guaranteed
to change once a week (more often than that usually though).

This is on Mozilla1.4b on Windows 2000, sp3.

Comment 7

[Nagi Peters]

Scheduler doen't do anything sinca about a month. now using 2003052309.

Comment 8

[Christian Franke]

Notify/Schedule worked for me with 1.3 but does nothing after upgrading to 1.4b
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030507].

Testcase: Notification for the daily Dilbert http://www.dilbert.com/ no longer
appears. No HTTP HEAD requests appear in the proxy log.

Comment 9

[Henning Schnoor]

This feature is totally broken and has been for ages - I've been testing Mozilla
since M18, and the bookmark notification never worked. Bug 107268 is also about
that issue, but there's nothing happening about it.

This also is *not* a regresseion - as I said, I tested this since M18, on both
Linux and Windows, different machines, and it never worked at all. It obviously
works under some circumstances (see other reports), but it was never reliable.

So, "regression" should be removed.

Comment 10

[Jan Varga [:janv]]

Attachment: patch

Comment 11

[jag (Peter Annema)]

Comment on attachment 124365 [details] [diff] [review]
patch

sr=jag

Comment 12

[Jan Varga [:janv]]

Comment on attachment 124365 [details] [diff] [review]
patch

jag probably meant r=jag

Comment 13

[Jan Varga [:janv]]

fixed on the trunk

Comment 14

[André Dahlqvist]

*** Bug 107268 has been marked as a duplicate of this bug. ***

Comment 15

[Henning Schnoor]

Is the fix already in some nightly build I can download - I guess it would be in
latest-nightly?

And will this make 1.4 final - would be good to have this feature finally
working, especially if 1.4 is to be the last release of the "old" suite.

Comment 16

[Jan Varga [:janv]]

Yes, it should be in the latest nightly, I landed the patch in the morning.
It might make 1.4 final if approved.

Comment 17

[Henning Schnoor]

I'm sorry, but this patch doesn't do it for me. I created a new profile, started
the latest nightly, and set up some bookmarks to be monitored for change. 

One of them is www.cnn.com, and I get a notification every minute now. 

Others I tried:

http://www.spiegel.de
http://www.heise.de
http://www.welt.de
http://www.heise.de/newsticker
http://www.heise.de/newsticker/data/em-30.05.03-000/

The last one here is an article which has a user forum, and is updated very
often (every time a user writes something). The page is created as static html,
not dynamically from a database.

With all these urls, I don't get any notofications at all, except like I said
cnn, which gets an alert every minute.

I fear the bug has to be re-opened :-(

Comment 18

[Henning Schnoor]

An update: I now deleted the cnn bookmark, but still get notifications the site
has changed - I don't think this should be happening.

Comment 19

[Jan Varga [:janv]]

This bug is about a regression which appeared after bookmarks rewrite to use
unique IDs. These IDs were used instead of urls, so it was absolutely impossible
to get a notification, since an ID looks like rdf:#$8L0BJ3

I believe that there are other bugs related to this feature, but they are *not*
part of this bug report. 

This patch should make things behave just like it was before 1.4a.

Comment 20

[Jan Varga [:janv]]

for example, see bug 110044

Comment 21

[Henning Schnoor]

Ok, thanks for the explanation - in this case, bug 107268 is not a dplicate of
this bug. since that one is open since 2001.

Comment 22

[Asa Dotzler [:asa]]

Comment on attachment 124365 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 23

[Paul Wyskoczka]

a=adt.  Please land this fix on the Mozilla 1.4 branch and add fixed1.4 to the
staus whiteboard

Comment 24

[Chris Petersen]

Verifying this is fixed on the trunk builds: (2003-06-02-08) Macho and
(2003-06-02-08) Win32. This fix missed todays branch (06/02) but will be in
tomorrow's branch. Need to check that build when it becomes available..

Comment 25

[Chris Petersen]

BTW, I tested this on cnn's site and mac.com (my personal homepage). I recieved
a alert when the content had been updated based on my notification schedule setting.

Comment 26

[Chris Petersen]

Verified on trunk

Comment 27

[Paolo Cascini]

Solaris build 2003060304 works fine.
Is there any way to change also the icon in the bookmarks Sidebar?
It would be a nice feature, I believe.

Comment 28

[Paolo Cascini]

I still get a weird problem with the website www.openzaurus.org. I get a
notification every minute altough it  didn't change in the meanwhile.
I am not sure if it is related with the bug 110044

Comment 29

[Chris Petersen]

Ok, This specific problem is fixed on the (06/03)branch. There are remaining
issues like bug 110044.

Comment 30

[Henning Schnoor]

Hi, since there seem to be a few people around here who know something about the
bookmark scheduling mechanism, could you please take a look at bug 207814 - that
is the new meta bug about the scheduler not working properly, which has been
created since the last bug tracking these issues was marked duplicate in error.

So, anyone who feels she/he can contribute to the bookmark scheduler, please
look at bug 207814. Thanks.