Closed Bug 204053 Opened 22 years ago Closed 22 years ago

Midas fontname doesn't work

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.4final

People

(Reporter: emaijala+moz, Assigned: Brade)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

grab StringValue if CStringValue returns an error
1.68 KB, patch
mkaply
: review+
sfraser_bugs
: superreview+
asa
: approval1.4+
Details | Diff | Splinter Review
corresponding docs changes which should've been fixed a few weeks ago
1.10 KB, patch
sfraser_bugs
: superreview+
asa
: approval1.4+
Details | Diff | Splinter Review
When using Midas, QueryCommandValue() for fontname doesn't work. Seems to me there's a clash with using C-strings instead of wide strings in some places. For example nsFontFaceStateCommand::GetCurrentState() uses SetStringValue() but QueryCommandValue() tries to get it using GetCStringValue() which fails because the type isn't the same. Without knowing anything more I wonder if QueryCommandValue() and others could just agree to always use [Get/Set]StringValue()?
Attached patch v1 (obsolete) — — Splinter Review
Attachment #123901 - Attachment is obsolete: true
The patch works great for me.
Attachment #123920 - Flags: review?(mkaply)
Comment on attachment 123920 [details] [diff] [review] grab StringValue if CStringValue returns an error r=mkaply
Attachment #123920 - Flags: review?(mkaply) → review+
Attachment #123920 - Flags: superreview?(sfraser)
Attachment #123925 - Flags: superreview?(sfraser)
Flags: blocking1.4?
Attachment #123925 - Flags: superreview?(sfraser) → superreview+
Comment on attachment 123920 [details] [diff] [review] grab StringValue if CStringValue returns an error I'd prefer we have an explicit policy about which commands use wide strings though.
Attachment #123920 - Flags: superreview?(sfraser) → superreview+
Comment on attachment 123925 [details] [diff] [review] corresponding docs changes which should've been fixed a few weeks ago seeking approval to land this documentation change for 1.4final (does not affect build)
Attachment #123925 - Flags: approval1.4?
Comment on attachment 123920 [details] [diff] [review] grab StringValue if CStringValue returns an error seeking approval to land this for 1.4final; the fix is to check for string if cstring check fails
Attachment #123920 - Flags: approval1.4?
Status: NEW → ASSIGNED
Keywords: nsbeta1, regression
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.4final
Comment on attachment 123925 [details] [diff] [review] corresponding docs changes which should've been fixed a few weeks ago a=asa (on behalf of drivers) for checkin to 1.4
Attachment #123925 - Flags: approval1.4? → approval1.4+
Comment on attachment 123920 [details] [diff] [review] grab StringValue if CStringValue returns an error a=asa (on behalf of drivers) for checkin to 1.4
Attachment #123920 - Flags: approval1.4? → approval1.4+
fix checked in for 1.4final
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Flags: blocking1.4?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: