204061 - Cannot login to POP3 mail server

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Andrei Leo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030430
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030430

Alert window says: 
"An error occured with the POP3 mail server. Mail server pop.yandex.ru responded:"

This is part of the mozilla mail log file:
0[2340a0]: Entering NET_ProcessPop3 12
0[2340a0]: POP3: Entering state: 1
0[2340a0]: POP3: Entering state: 2
0[2340a0]: POP3: Entering state: 4
0[2340a0]: RECV: (null)
0[2340a0]: Entering NET_ProcessPop3 27
0[2340a0]: POP3: Entering state: 29
0[2340a0]: POP3: Entering state: 24
0[2340a0]: POP3: Entering state: 25

Moz 1.4b 20030421 is working ok

I know that it might be 203219 but it suppose to be fixed in 20030430 build

Reproducible: Always

Steps to Reproduce:

Comment 1

[Christian Eyrich]

The server is one of those sending their Respnsens spread over multiple TCP
packages.
+OK POP Ya!
<[e-mail]>
\r\n

WaitForStartOfConnectionResponse() and WaitForResponse() can handle this - they
pause and get the next fragment the next time called.
The problem is, that in
case POP3_WAIT_FOR_START_OF_CONNECTION_RESPONSE in ProcessProtocolState()
we don't check if WaitForStartOfConnectionResponse() succeeded but continue with
the authentication procedure.

Fix follows.

Comment 2

[Christian Eyrich]

Attachment: proposed patch

Two solutions where possible. Either we move the whole stuff after the call to
WaitForStartOfConnectionResponse() from the 
case POP3_WAIT_FOR_START_OF_CONNECTION_RESPONSE
to the if(*line == '+') in WaitForStartOfConnectionResponse().
Or we leave this stuff were it is and just pack it into an ifthiswaitsucceeded.


I like the second more and so I've done this.

Comment 3

[David :Bienvenu]

Thx, looks good, but can I get a -uw diff? 

Comment 4

[Christian Eyrich]

Attachment: same patch -uw

Comment 5

[David :Bienvenu]

Comment on attachment 122666 [details] [diff] [review]
same patch -uw

r=bienvenu, great, thx.
This will have to wait for 1.4b, and get into 1.4 final, since 1.4b is
basically done.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 122666 [details] [diff] [review]
same patch -uw

r/sr/a=sspitzer for 1.4 final.

this might be worth taking for 1.4 beta, too.

if you can't read your pop mail, that's bad.

Comment 7

[(not reading, please use [e-mail] instead)]

david said he was going to land this for 1.4 final.

Comment 8

[David :Bienvenu]

fix checked in

Comment 9

[Christian Eyrich]

*** Bug 205342 has been marked as a duplicate of this bug. ***