Closed
Bug 204124
Opened 21 years ago
Closed 21 years ago
minor codesize optimizations for nsNetUtil.h
Categories
(Core :: Networking, defect, P5)
Core
Networking
Tracking
()
VERIFIED
FIXED
mozilla1.5alpha
People
(Reporter: darin.moz, Assigned: darin.moz)
References
()
Details
(Keywords: memory-footprint)
Attachments
(1 file)
44.24 KB,
patch
|
alecf
:
superreview+
|
Details | Diff | Splinter Review |
minor codesize optimizations for nsNetUtil.h biggest change is to avoid this pattern: nsCOMPtr<nsIFoo> foo; rv = func(getter_AddRefs(foo)); if (NS_FAILED(rv)) return rv; rv = blah(); if (NS_FAILED(rv)) return rv; since each return statement would have code to call the destructor (true at least with GCC 3.2). also, the patch i prepared cleans up nsNetUtil.h a bit.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #122247 -
Flags: superreview?(alecf)
Attachment #122247 -
Flags: review?(dougt)
Assignee | ||
Comment 2•21 years ago
|
||
not on the radar for 1.4
Status: NEW → ASSIGNED
Priority: -- → P5
Target Milestone: --- → mozilla1.5alpha
Comment 3•21 years ago
|
||
Comment on attachment 122247 [details] [diff] [review] v1 patch this is great stuff.. might be nice to see a -bw patch, but overall this looks good. sr=alecf
Attachment #122247 -
Flags: superreview?(alecf) → superreview+
Assignee | ||
Comment 4•21 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
Attachment #122247 -
Flags: review?(dougt)
VERFIED as code fix. http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsNetUtil.h&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/public&command=DIFF_FRAMESET&rev1=1.65&rev2=1.66
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•