204138 - Cannot enumerate all event properties without exceptions being thrown

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

JavaScript: The Definitive Guide and other sources recommend a small snippet of
code to enumerate all the properties of an object; it goes roughly like this:

    var eventProperties = "";
    for (prop in e) {
      eventProperties += prop + " : '" + e[prop] + "'\n";
    }

Doing this for event object stopped working some time after 1.0. Now you get an
exception thrown:

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIDOMPopupBlockedEvent.requestingWindowURI]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
http://www.mozilla.org/xmlextras/get.xhtml :: myfunc :: line 57"  data: no]

I'll attach a testcase.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: testcase

Comment 2

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 3

[Asa Dotzler [:asa]]

bryner or ben, can you look at this?

Comment 4

[Paul Wyskoczka]

ADT: Nominating topembed

Comment 5

[saari (gone)]

->bryner

Comment 6

[Michael Buckland]

Discussed in topembed bug triage.  Plussing.

Comment 7

[Brian Ryner (not reading)]

Attachment: fix

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 123192 [details] [diff] [review]
fix

+  NS_WARNING("Tried to get requestingWindowURI for non-popupblocked event!");

Given that this code will be trigged if someone simply enumerates the
properties of an event, I don't like this warning. I'd say take it out.

sr=jst

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 123192 [details] [diff] [review]
fix

a=asa (on behalf of drivers) for checkin to 1.4

Comment 10

[Brian Ryner (not reading)]

checked in.

Comment 11

[Prashant Desale]

Verified with 2003-06-12-04-trunk