204386 - Allow setting Image.src to empty

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

this should simply consist of removing a few lines from ImageLoadingContent
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsImageLoadingContent.cpp#361

note, both NS4 and MSIE 6 show a broken image when src is set to empty.
See http://web.mit.edu/bzbarsky/www/testcases/image-loading/setAttrToEmpty.html
for a testcase of setting .src to "".

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 122789 [details] [diff] [review]
patch

Add { } around the body of the else (since the "if" has them) and add a short
comment explaining why you have to reset the intrinsic size (so that we will
recalculate it in GetDesiredSize).

r+sr=me with those changes.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/base/src/nsImageLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsImageLoadingContent.cpp,v  <-- 
nsImageLoadingContent.cpp
new revision: 1.12; previous revision: 1.11
done
Checking in layout/html/base/src/nsImageFrame.cpp;
/cvsroot/mozilla/layout/html/base/src/nsImageFrame.cpp,v  <--  nsImageFrame.cpp
new revision: 1.282; previous revision: 1.281
done

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

urg, I just realized that I didn't address bz's comments when checking in :/ I
am _really_ sorry about that.

I'll fix that tomorrow.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, comments addressed:
Checking in nsImageFrame.cpp;
/cvsroot/mozilla/layout/html/base/src/nsImageFrame.cpp,v  <--  nsImageFrame.cpp
new revision: 1.283; previous revision: 1.282
done

Comment 6

[Boris Zbarsky [:bzbarsky]]

For the record, due to other issues this caused some slowness with mozillazine
pages -- see bug 209242