204411 - charset change does not affect channel topic

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Max Alekseyev]

Chatzilla 0.8.26 [Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.4b) Gecko/20030430]

/charset command doesn't affect channel topic shown neither at channel view
title nor at chatzilla window title.

Comment 1

[Samuel Sieb]

Please try the latest version of chatzilla and see if this is fixed.

Comment 2

[Max Alekseyev]

I see the bug in
Chatzilla 0.9.35 [Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a) Gecko/20031009]

Comment 3

[Samuel Sieb]

latest is 0.9.40.  There were a lot of charset bugs fixed in the last couple of
versions.

Comment 4

[Max Alekseyev]

The bug is still in ChatZilla 0.9.40 as well.

Comment 5

[Max Alekseyev]

Probably I need to clarify what's this bug is about.

To reproduce:
1. Open chatzilla
2. Connect to some channel whose topic is codepage-dependent
(or create a channel and set up such a topic there)
3. Try to set up different codepages with ``/charset'' command
4. Notice that /charset doesn't affect the topic unless you re-join the channel

Expected result: /charset should affect topic immediately without having to
re-join the channel

Comment 6

[Samuel Sieb]

You can probably fix this by typing "/topic" (no parameters).

Comment 7

[James Ross]

This wouldn't be that easy to do in the 'expected' way, having to keep a
non-decoded version around and re-decode it when you change the charset. I think
a better solution is simply to send out a /topic when you change the charset.

Comment 8

[Max Alekseyev]

Related bug 225950

Comment 9

[James Ross]

Attachment: Re-request topic when charset is changed

There's also some trailing whitespace that got removed by my editor here. :)

Comment 10

[:Gijs (he/him)]

Comment on attachment 180937 [details] [diff] [review]
Re-request topic when charset is changed

Requesting approval for harmless CZ patches

Comment 11

[Mike Shaver (:shaver emeritus)]

Comment on attachment 180937 [details] [diff] [review]
Re-request topic when charset is changed

a=shaver

Comment 12

[James Ross]

Checked in -> FIXED.