Closed
Bug 204426
Opened 22 years ago
Closed 22 years ago
Warnings in nsTypeAheadFind.cpp/nsTypeAheadFind.h
Categories
(SeaMonkey :: Find In Page, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
aaronlev
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
In file included from /swap/BEOS/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp:115:
/swap/BEOS/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.h:270: warning: `class nsTypeAheadController' has virtual functions but non-virtual destructor
/swap/BEOS/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp: In method `nsresult nsTypeAheadController::DoCommand(const char *)':
/swap/BEOS/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp:2887: warning: unused variable `nsresult rv'
Attachment #122456 -
Flags: superreview?(dbaron)
Attachment #122456 -
Flags: review?(aaronl)
Comment on attachment 122456 [details] [diff] [review]
changes
I think we should turn off the warning about having non-virtual destructors in
classes with virtual methods, but whatever...
Attachment #122456 -
Flags: superreview?(dbaron) → superreview+
|
||
Updated•22 years ago
|
Attachment #122456 -
Flags: review?(aaronl) → review+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•