204431 - The 5-arg form of addDirectory() incorrectly returns error to script

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Daniel Veditz [:dveditz]]

The 5-arg form of addDirectory() will always return UNEXPECTED_ERROR to the
XPInstall script, although the action will correctly proceed and the real
success or error can be retrieved through the resetError()/getLastError() mechanism.

Comment 1

[Daniel Veditz [:dveditz]]

Attachment: Fix v1

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 122462 [details] [diff] [review]
Fix v1

Sean, please review. part of the big 125106 landing flipped the sense of the
code here but missed flipping the comparison in this one case.

Comment 3

[Sean Su]

Comment on attachment 122462 [details] [diff] [review]
Fix v1

Just checked the patch to bug 125106.  This was the only one missed.
Thanks Dan.

r=ssu

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 122462 [details] [diff] [review]
Fix v1

sr=[e-mail]

Comment 5

[Sean Su]

Comment on attachment 122462 [details] [diff] [review]
Fix v1

trivial fix.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 122462 [details] [diff] [review]
Fix v1

a=sspitzer

Comment 7

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 8

[Sean Su]

patch checked in.

Comment 9

[Grace Bush]

Sean,
Did this get checked in? I am not seeing the code fix.  The test case works.

Comment 10

[Sean Su]

yes, this has been checked in:
  http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsJSInstall.cpp#464

Comment 11

[Grace Bush]

sorry, had wrong file :(
verified