Closed Bug 204456 Opened 22 years ago Closed 22 years ago

remove #define error codes

Categories

(Core :: XSLT, defect)

Product:
Core
Component:
XSLT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: axel, Assigned: axel)

References

Details

Attachments

(1 file)

kill 3 out of 4 nserror aliases in txError.h
10.47 KB, patch
sicking
: review+
axel
: superreview+
sspitzer
: approval1.4b+
Details | Diff | Splinter Review
patch coming up to remove 3 out of 4 #define'd error codes in txError.h. We should use the good error codes we have, now. I left NS_ERROR_XPATH_INVALID_ARG, as I'm not sure whether we wanna change the error string for that, but that can come later on, when we do the other error strings as well. This is cleanup only.
Status: NEW → ASSIGNED
Comment on attachment 122482 [details] [diff] [review] kill 3 out of 4 nserror aliases in txError.h requesting r, got sr=peterv on irc
Attachment #122482 - Flags: superreview+
Attachment #122482 - Flags: review?(bugmail)
Blocks: 47719
Comment on attachment 122482 [details] [diff] [review] kill 3 out of 4 nserror aliases in txError.h this patch is a low-to-no risk cleaning of txError.h. Previous patches just forgot to remove obsolete error codes and their use. This is actually more blocking 2 patches further improving error reporting in XSLT. At least 1 of them (bug 47719) might be nice to have in 1.4, so risk vs. benefit makes me request approval for this patch now.
Attachment #122482 - Flags: approval1.4b?
Comment on attachment 122482 [details] [diff] [review] kill 3 out of 4 nserror aliases in txError.h a=sspitzer
Attachment #122482 - Flags: approval1.4b? → approval1.4b+
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
mass verifying
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: