204532 - more data could be const in content

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Andrew Taylor]

There are a number of variables in mozilla/content that could be made const. 
Making them const allows some optimizations not otherwise available, such as
sharing more data between multiple running instances.

Comment 1

[Andrew Taylor]

Attachment: constifies some variables in content

Here is a patch that constifies some variables in content.

Comment 2

[Boris Zbarsky [:bzbarsky]]

> -static char* kNullPointer = "null pointer";
> +static const char kNullPointer[] = "null pointer";

How about just copying this string to the one place where it's used (in an
NS_PRECONDITION) and eliminating the symbol entirely?  So that should read:

  NS_PRECONDITION(aInput, "Null input stream pointer");

instead of

  NS_PRECONDITION(nsnull != aInput, kNullPointer);

Comment 3

[Alec Flett]

Comment on attachment 122522 [details] [diff] [review]
constifies some variables in content

nice!
sr=alecf

Comment 4

[Andrew Taylor]

Attachment: constifies some variables in content - v2

Here is a new patch that implements Boris' suggestion.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 122589 [details] [diff] [review]
constifies some variables in content - v2

r=me; please poke me when this gets approval (if you decide to ask for it) or
the tree reopens for 1.5a.

Comment 6

[Alec Flett]

Comment on attachment 122589 [details] [diff] [review]
constifies some variables in content - v2

sr=alecf
yeah, lets wait on 1.5alpha for this.. I had an ugly landing of some
constifying at one point.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Checked in.