204634 - remove dynamically allocated hashtable in xpcom where possible.

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

Comment 1

[Benjamin Smedberg]

This sounds very general... do you have specifics here?

Comment 2

[Alec Flett]

well, what he's referring to is class members that have this

class nsFoo {

    nsHashtable* mHashtable;
}

nsFoo::nsFoo() {
  mHashtable = new nsHashtable();
}

nsFoo::~nsFoo() {
  delete mHashtable;
}

when in reality, we could save an allocation by just saying:

class nsFoo {

    nsHashtable mHashtable;
};

so that its not new/delete'ed...

Comment 3

[Alec Flett]

(so if anyone wants to go out and FIND this pattern in the tree (Especially in
mozilla/xpcom) it would make it way easier to fix them. If that person wants to
attach patches, even better! I'll review.

Comment 4

[Doug Turner (:dougt)]

patch coming up.

Comment 5

[Doug Turner (:dougt)]

Attachment: update for xpcom (not including obsolete)

Comment 6

[Alec Flett]

Comment on attachment 124081 [details] [diff] [review]
update for xpcom (not including obsolete)

r=alecf

Comment 7

[Doug Turner (:dougt)]

Checking in components/nsNativeComponentLoader.cpp;
/cvsroot/mozilla/xpcom/components/nsNativeComponentLoader.cpp,v  <-- 
nsNativeComponentLoader.cpp
new revision: 1.94; previous revision: 1.93
done
Checking in components/nsNativeComponentLoader.h;
/cvsroot/mozilla/xpcom/components/nsNativeComponentLoader.h,v  <-- 
nsNativeComponentLoader.h
new revision: 1.18; previous revision: 1.17
done
Checking in components/xcDll.cpp;
/cvsroot/mozilla/xpcom/components/xcDll.cpp,v  <--  xcDll.cpp
new revision: 1.73; previous revision: 1.72
done
Checking in ds/nsObserverService.cpp;
/cvsroot/mozilla/xpcom/ds/nsObserverService.cpp,v  <--  nsObserverService.cpp
new revision: 3.28; previous revision: 3.27
done
Checking in glue/standalone/nsGREDirServiceProvider.cpp;
/cvsroot/mozilla/xpcom/glue/standalone/nsGREDirServiceProvider.cpp,v  <-- 
nsGREDirServiceProvider.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in proxy/src/nsProxyEventPrivate.h;
/cvsroot/mozilla/xpcom/proxy/src/nsProxyEventPrivate.h,v  <--  nsProxyEventPrivate.h
new revision: 1.35; previous revision: 1.34
done
Checking in proxy/src/nsProxyObjectManager.cpp;
/cvsroot/mozilla/xpcom/proxy/src/nsProxyObjectManager.cpp,v  <-- 
nsProxyObjectManager.cpp
new revision: 1.53; previous revision: 1.52
done

should I just mark this fixed, or should we look expand this bug to other modules?

Comment 8

[Alec Flett]

seperate bugs for seperate modules...IMO

Comment 9

[Doug Turner (:dougt)]

k