204750 - Title of the window : "Select Download Directory" is not localizable

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Bugzilla FR]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030429 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030429 Mozilla Firebird/0.6

Lines and files in lxr : 

http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-navigator.xul#71
and : 
http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-downloads.xul#40

I know you are aware of this pb but we want to make the best localization
possible :)
Thanks


Reproducible: Always

Steps to Reproduce:
1. Outils
2. Options
3. General
4. Download directory selection windows is not localizable.

Comment 1

[Sébastien Delahaye]

As the comment in the source code says, it needs to be localizable.
-> Confirming

Comment 2

[Mike Connor [:mconnor]]

While I'm working on bug 178227, I'll include this as part of the localization
required for what I'm doing there.

--> Dependent on 178227

Comment 3

[Bugzilla FR]

As you are here. I don't know if this is related in term of sources modifications
but there is another bug who block the localization : 
http://bugzilla.mozilla.org/show_bug.cgi?id=204773

Comment 4

[Mike Connor [:mconnor]]

taking, target to 0.7
if patch in 178227 is rejected, will at least create patch for this bug

Comment 5

[Mike Connor [:mconnor]]

er, taking

Comment 6

[noririty]

fixed by bug 178227

Comment 7

[Simon Paquet [:sipaq]]

Reopening

Comment 8

[Simon Paquet [:sipaq]]

Noririty, while you fixed the issue in pref-navigator.xul, you forgot the stuff
in pref-downloads.xul as described in the original bugreport. Reassigning to you.

Comment 9

[noririty]

right, taking.

Comment 10

[Mike Connor [:mconnor]]

Where is pref-download.xul supposed to be?  It seems like an orphaned file since
nothing in the entire mozilla source links to the file.  The only thing I found
in LXR searching on pref-download.xul was the initPanel call within the file itself.

I just had assumed that it was part of a deprecated older prefs dialog and left
it out of the patch for sanity's sake.

Comment 11

[Simon Paquet [:sipaq]]

You're right, Mike. This seems to be a leftover of the pref menu before Ben's
great overhaul at the end of 2002. Noririty, I'm marking this fixed again, can
you delete this file from cvs?

Comment 12

[noririty]

checked in.

Comment 13

[Simon Paquet [:sipaq]]

Thanks noririty. Marking VERIFIED