205017 - Uninitialized variables in layout/html/base/src/nsPresShell.cpp

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[tenthumbs]

Taking a guess at the component.

Gcc says

nsPresShell.cpp:7864: warning: `PRUint8 rc' might be used uninitialized in \
 this function
nsPresShell.cpp:7864: warning: `PRUint8 gc' might be used uninitialized in \
 this function

and the code is:

    7858       PRUint32 color;
    7859       PRUint32 color2;
    7860       if (aColor != 0) {
    7861         color  = aColor;
    7862         color2 = NS_RGB(0,0,0);
    7863       } else {
    7864         PRUint8 rc,gc,bc = 0;
    7865         if (counter->mCount < 5) {
    7866           rc = 255;
    7867           gc = 255;
    7868         } else if ( counter->mCount < 11) {
    7869           gc = 255;
    7870         } else {
    7871           rc = 255;
    7872         }
    7873         color  = NS_RGB(rc,gc,bc);
    7874         color2 = NS_RGB(rc/2,gc/2,bc/2);
    7875       }

and, sure enough, rc and gc aren't initialized. I have a feeling line 7864 should be
   PRUint8 rc = 0,gc = 0,bc = 0
but I could well be wrong.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fortunately this is in debugging code that nobody I know of uses.  That said,
it's a pretty obvious fix.

Comment 2

[tenthumbs]

If no one's using it why not remove it and reduce bloat?

Comment 3

[timeless]

Attachment: init to 0

Comment 4

[timeless]

.

Comment 5

[timeless]

checked in