205213 - [FIX]Cannot back to non-existant destination anchor after visiting another destination anchor

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Jason Barnabe (np)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030510
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030510

Going to an URL with a destination anchor (A HREF="foo.html#Anchor") that is not
specified in that document (with A NAME) opens to the top of that page. If you
click on a valid destination anchor link, it'll take you to that spot on the
page. However, if you then click on the back button, it doesn't return to the
top of the page. Subsequent back clicks also do nothing.

Reproducible: Always

Steps to Reproduce:
1. Go to the link ("SARS" is not a named destination anchor on that page)
2. Click on "HIV".
3. Click back button
Actual Results:  
Nothing

Expected Results:  
Gone back to the top of the page.

Comment 1

[Jason Barnabe (np)]

Attachment: part one of testcase

Comment 2

[Jason Barnabe (np)]

Attachment: part two of testcase

Part one and part two must be together in the same folder. I don't think this
will work from Bugzilla.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127217 [details] [diff] [review]
Proposed patch

The key here is not propagating the return value of GoToAnchor to our caller...
 The rest is minor cleanup.

Comment 6

[jag (Peter Annema)]

Comment on attachment 127217 [details] [diff] [review]
Proposed patch

r=jag

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 8

[Jason Barnabe (np)]

Verified fixed. Thanks.