Closed
Bug 205262
Opened 21 years ago
Closed 21 years ago
warning nsSampleWordBreaker::Next was hidden by nsSemanticUnitScanner::Next
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
8.37 KB,
patch
|
smontagu
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
/swap/BEOS/mozilla/intl/lwbrk/src/nsSampleWordBreaker.h:72: warning: `nsSampleWordBreaker::Next(const PRUnichar *, unsigned int, unsigned int, PRUint32 *, PRBool *)' was hidden In file included from /swap/BEOS/mozilla/intl/lwbrk/src/nsSemanticUnitScanner.cpp:39: /swap/BEOS/mozilla/intl/lwbrk/src/nsSemanticUnitScanner.h:51: warning: by `nsSemanticUnitScanner::Next(const P RUnichar *, int, int, int, PRInt32 *, PRInt32 *, PRBool *)'
Attachment #123016 -
Flags: superreview?(dbaron)
Attachment #123016 -
Flags: review?(smontagu)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 123016 [details] [diff] [review] proposal (change nsIWordBreaker::Next to nsIWordBreaker::NextWord) Looks OK, but if you're already improving the English of the comments, you can do better than // if we are in chinese mode, return one han letter at a time // we should not do this if we are in Japanese or Korean mode r=smontagu anyhow
Attachment #123016 -
Flags: review?(smontagu) → review+
Attachment #123016 -
Flags: superreview?(dbaron) → superreview+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•