205310 - PNG image is displayed as garbage

Status: RESOLVED FIXED

(Core Graveyard :: Image: Painting, defect)

Description

[Haakon Riiser]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030511
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030511

http://images.freshmeat.net/screenshots/3088.png is displayed as
http://folk.uio.no/hakonrk/mozilla_image_bug.png

Reproducible: Always

Steps to Reproduce:
Load the following image:

  http://images.freshmeat.net/screenshots/3088.png 
 
If it looks okay at first, make Mozilla redraw by
minimizing/maximizing the window, selecting the image with
the mouse.
Actual Results:  
http://folk.uio.no/hakonrk/mozilla_image_bug.png

Expected Results:  
http://images.freshmeat.net/screenshots/3088.png

Happens even if I delete ~/.mozilla/ and run with a clean configuration.

OPERATING SYSTEM
================
Slackware 9.0 (also verified on Red Hat 7.3)
Linux 2.4.20 i686
 
SYSTEM LIBRARIES
================
libpthread-0.10.so
libdl-2.3.1.so
libgtk-1.2.so.0.9.1
libgdk-1.2.so.0.9.1
libgmodule-1.2.so.0.0.10
libglib-1.2.so.0.0.10
libXi.so.6.0
libXext.so.6.4
libX11.so.6.2
libm-2.3.1.so
libc-2.3.1.so
ld-2.3.1.so
 
MOZILLA VERSIONS
================
Mozilla 1.3
Mozilla 1.3.1
Mozilla 1.4b
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030511

Comment 1

[José Jeria]

Image looks good on windows 2000. build 2003051108.

Comment 2

[Andrew Schultz]

confirmed with linux trunk 20030510
this regressed between 2003041205 and 2003041408

Comment 3

[tenthumbs]

WFM with my 5-10 Linux trunk build on a system that started out as Slackware
8.1. The garbage looks a lot like a video driver problem. Does it still occur if
you restart X without hardware acceleration?

Comment 4

[Haakon Riiser]

Yes, it happens even when

  Option "NoAccel" "true"

I can also reproduce the bug on completely different machines.
(A workstation with GeForce 3 Ti200, a laptop with ATI Rage, another
workstation with a Matrox G400, and more.)

Are you sure you are unable to reproduce the bug?  Did you try to
minimize->maximize Mozilla?  Did you try to select the image by marking
it with the mouse (as in text selection)?

Comment 5

[Haakon Riiser]

I just noticed that you ([e-mail]) had built your
own Mozilla.  I tried Mozilla 1.3 that comes bundled with
Slackware 9.0, and the bug is NOT reproducible there.  This particular
binary was also built from source, so it appears that just the
pre-built binaries from mozilla.org are affected.  Can anyone else
confirm this?

Comment 6

[tenthumbs]

I built mine with gcc 3.2.3, Slackware 9 uses3.2.2. I think the nightlies are
built with 2.95.3. Might be important, might not.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

I am using my self-compiled build (gcc 3.2.something, gtk2) and am also seeing
this bug.

Comment 8

[tenthumbs]

Attachment: png w/o alpha channel

I still can't reproduce this but I noticed that the image has a useless alpha
channel (all opaque). This is the same image without an alpha channel. Does it
render badly?

Comment 9

[Haakon Riiser]

No, it looks just fine.  But here's something to try for those of you
who are seeing this bug.  Try saving the original freshmeat PNG
locally and open it from there.  Can you reproduce the bug on
your local copy?  I can't!  How is this even possible?  I'm linking
directly to the PNG on freshmeat, so why should it matter where
Mozilla gets it from?

Comment 10

[Johannes la Poutre]

Confirmed with build 2003041609 (SuSE Linux 8.1)
Additional notes:
- locally saved img displays OK
- saved, served from Apache 1.3.26 displays OK
- attached w/o alpha displays OK
- the Slashdot hosted img displays for a split second OK after loading
sometimes, then displays the "random" noise.

The HTTP headers from Slashdot (Apache 1.3.27) and local server are similar.

Comment 11

[Rapsys|Phoenix]

I have similar problems with png picture : see my screenshot of lea-linux.org!!!

I have became with the release 1.4 and is always present in the latest
nightbuild (take 3 minutes before here...)

my screenshot : http://site.voila.fr/rapsys/fucking_display.png

I have saved the image witch is worst displayed ant it's perfect show by the
gimp and electric eye...

It's does be a bug in mozilla....

I use the latest snapshot and i reproduct the bug from the 1.4 mozilla...

I am on a mdk 9.2, The bug append in the 9..1 (i don't know if it was present in
my 9.0 mdk...)

I have a nvidia card (with propriétar drivers...), a athlon-xp 2100+, a MSI
KT333-ARU, 512DDR, KDE 3.1.3mdk, 2.4.22-21mdkenterprise...

sorry for my pore english I am french...

Comment 12

[Rapsys|Phoenix]

Attachment: How I see some png files...

How I see some png files...

Comment 13

[tor]

Attachment: handle 0->1 bit alpha promotion

Comment 14

[tor]

Attachment: only the relevant changes this time...

Comment 15

[tor]

Checked in on trunk.

Comment 16

[tor]

Comment on attachment 138009 [details] [diff] [review]
only the relevant changes this time...

Longstanding bug with a simple fix that caused some PNGs to display 
as garbage.

Comment 17

[chris hofmann]

Comment on attachment 138009 [details] [diff] [review]
only the relevant changes this time...

a=chofmann for 1.6

Comment 18

[tor]

Checked in on MOZILLA_1_6_BRANCH.

Comment 19

[tor]

Checked in on 1.4 branch - verbal approval from mkaply.