205440 - JavaScript error in internetresults.xul/.js

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Karsten Düsterloh]

[This is another spin-off of my patch of bug 57654.]

1. "Error: switchTab is not defined"
- enable advanced search in preferences->navigator->internet search
- open the sidebar search panel
- search something within *multiple* search engines
==> the combined results will be shown in the browser window
- select a single search engine from the drop down box in the browser window
==> the JavaScript console will show "Error: switchTab is not defined"

2. function not always returning a value
In internetresults.js, the event handler functions "listSelect" and "listClick"
do not always return a value.


Patch is forthcoming.

Comment 1

[Karsten Düsterloh]

Attachment: very small and simple patch

This patch fixes the missing inclusion of search-panel.js in
internetresults.xul, the associated getElementById problem in search-panel.js,
and sets return values in internetresults.js.

Comment 2

[Karsten Düsterloh]

Attachment: incorporating jag's comments from IRC

- return savely from SwitchPanel if there's no sidebar search panel
- removed padding space

Comment 3

[jag (Peter Annema)]

Comment on attachment 124867 [details] [diff] [review]
incorporating jag's comments from IRC

Sorry for not looking at this earlier.

Is that try/catch really needed there?

Would it be better to move switchTab into shared.js so you can avoid having to
include search-panel.js in internetresults.xul?

If your answer is no, sr=jag

Comment 4

[Karsten Düsterloh]

Attachment: suggested changes from comment #3

- rewrite of the switchTab function without try{}catch by using available
functions; cruft deleted
- moving switchTab to shared.js meant to move getNavigatorWindow also

Comment 5

[jag (Peter Annema)]

Comment on attachment 126263 [details] [diff] [review]
suggested changes from comment #3

sr=jag.

Comment 6

[Karsten Düsterloh]

Comment on attachment 126263 [details] [diff] [review]
suggested changes from comment #3

taking over (unconditional) r+ from first patch

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, marking fixed