205534 - text-zoom no longer zooms text fields

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Pascal Chevrel:pascalc]

build 2003051204 WinXP

1 go to http://www.google.com/
2 type some text in the seach field
3 increase text size with text-zoom

actual result : font sizes increase but not into the text field
expected result : font-size increases in the text field too

This is a regression, it works OK in 1.0.x and 1.3

This problem was reported by a visually impaired person in
netscape.mozilla.user.general

original post :

"One feature I've liked about Mozilla is the way it can
display text sizes. By pressing Ctrl and + or - you can
control the size of the text on web pages from very small to
very big. This is a great feature for a visually impaired
person like myself. This is especially helpful when it comes
to text fields.  When I say text fields I mean those fields
where you enter text like on search engines. In Mozilla 1.3
when you change the text size, you also change the text
field size. This doesn't seem to be the case with 1.4b. The
text field stays the same size unless you go to fonts and
set a larger size in the "Minimum Font Size" box.
Does anyone know if this will be the behavior of 1.4 final?

As always, thank you very much"

Comment 1

[Pascal Chevrel:pascalc]

This is an annoying accessibility regression for people with sight problem,
since commercial products will be based on 1.4, is it a blocker ?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This works for me in a current Mozilla Firebird build (newer that 1.4b).  Do you
still see the problem in current builds.  I can't think what would have broken
this, though.

Comment 3

[Adam Hauner]

David: using 1.4b I'm able to reproduce on this Bugzilla page with Ctrl++
shortcut. Just downloading actual nightbuild, so I'll retest.

Comment 4

[Pascal Chevrel:pascalc]

David, my build IS a current build ;-) : 2003 05 12 04 

I can also reproduce it on a current firebird build :
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030511 Mozilla
Firebird/0.6

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Hmm, so I see the problem on Windows -- and it seems to be Windows-only.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 123174 [details] [diff] [review]
patch

This is a simple fix, inside an |#ifdef XP_WIN| that should probably move to
other code, except that it depends on the default font size.  This probably
broke with some text zoom cleanup that I did.

Comment 8

[Brendan Eich [:brendan]]

Let's get this into 1.4, I say.

How did it regress?

/be

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The regression was from font zoom changes I made for bug 154751 (see bug 154751
comment 15).  (The regression itself was caused by cleanup that I didn't really
need to make, but I wanted to make the code less complicated and avoid passing
an |aZoom| parameter around as much.)

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 123174 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.4

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2003-05-14 15:37 PDT.