205594 - embedded mozilla gtk2 is not accessibility enabled.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Bolian Yin]

Comment 1

[Bolian Yin]

Attachment: patch

Comment 2

[Bolian Yin]

Comment on attachment 123775 [details] [diff] [review]
patch

This patch will make gtkmozembed accessible. can you review it?

Comment 3

[Christopher Blizzard (:blizzard)]

Comment on attachment 123775 [details] [diff] [review]
patch


>+
>+    nsCOMPtr<nsIWebNavigation> webNav = do_QueryInterface(webBrowser);
>+    NS_ENSURE_TRUE(webNav, nsnull);

The web navigation object is already stashed locally as mNavigation, so you
shouldn't have to get it again.

>Index: EmbedPrivate.h
>===================================================================
>RCS file: /cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrivate.h,v
>retrieving revision 1.18
>diff -u -r1.18 EmbedPrivate.h
>--- EmbedPrivate.h	9 Mar 2003 07:08:40 -0000	1.18
>+++ EmbedPrivate.h	20 May 2003 05:32:20 -0000
>@@ -104,6 +104,10 @@
>   void        ChildFocusIn (void);
>   void        ChildFocusOut(void);
> 
>+#ifdef ACCESSIBILITY
>+  void *GetAtkObjectForCurrentDocument();
>+#endif

All of the accessibility code requires gtk2, so we can only define
accessibility for gtk2.  Might be easiest to do as part of the Makefile and
then just use the ACCESSIBILITY definition in the actual source files.

Comment 4

[Bolian Yin]

Attachment: patch_v2

I remember MOZ_ACCESSIBILITY_ATK can be used in the code for the purpose. But
MOZ_ACCESSIBILITY_ATK cannot be used in Makefile. So I still use ACCESSIBILITY
in Makefile, I think it is harmless.
also use mNavigation on Blizzard's suggestion.

Comment 5

[Christopher Blizzard (:blizzard)]

Comment on attachment 123858 [details] [diff] [review]
patch_v2

r=blizzard

Comment 6

[Bolian Yin]

checked in Trunk.

Comment 7

[Marco Pesenti Gritti]

Forgive my ignorance but is this all what was needed to make embedding apps
accessible or is there work left to do in the application itself ?
Thanks a lot to have worked on this btw.

Comment 8

[Bolian Yin]

First, I should say it only works on Gnome2 Desktop.
If your application is base on Gtk+-2.0 and it is already accessible, then the
embeded mozilla is also accessible, no more work needed. 
But I only tested in TestGtkEmbed, not a real application, so there maybe some
bugs left there. If you find problems, please file bugs. 
Thanks for concerning it.