205598 - History displays 0..6 instead of Today/Yesterday/etc

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Packaging, defect)

Description

[Mike Pinkerton (not reading bugmail)]

since we moved back to the trunk, history stopped displaying folder names
correctly because we're missing the dtd in the jar file

patch upcoming

Comment 1

[Mike Pinkerton (not reading bugmail)]

changing product

Comment 2

[Mike Pinkerton (not reading bugmail)]

blocks 1.4final

Comment 3

[Mike Pinkerton (not reading bugmail)]

Attachment: add history dtd to embed manifest

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 123235 [details] [diff] [review]
add history dtd to embed manifest

needing r/sr on this for camino

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 123235 [details] [diff] [review]
add history dtd to embed manifest

I'm not sure I like this.  Global history isn't really part of the "embedding
build" currently; Camino pulls in Mozilla's global history implementation
separately.  So, it seems to me that this should be something camino-specific. 
Maybe we should create a custom jar file for Camino?

Comment 6

[Simon Fraser [no longer active]]

I agree that we shouldn't pollute the embedding manifest.

Comment 7

[Mike Pinkerton (not reading bugmail)]

i assert the embedding manifest is a farce, needs to be totally refactored to be
of any use to any app, and is basically useless in its current form.

Comment 8

[Simon Fraser [no longer active]]

That's absolutely true. We don't have a good mechanism in place to allow for
different embedders to grab different things.

Comment 9

[Mike Pinkerton (not reading bugmail)]

fixed by adding a build phase that manually adds the file to embed.jar before we
copy it from dist.