205603 - Cleanup warnings in xul..grid

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[timeless]

/mnt/ibm/mozhack/mozilla/layout/xul/base/src/grid/nsGridLayout2.cpp:
 In method `nsresult nsGridLayout2::GetMinSize(nsIBox *, nsBoxLayoutState &, nsSize &)':
122: warning: unused variable `class nsGridRow * row'
134: warning: unused variable `class nsGridRow * row'
 In method `nsresult nsGridLayout2::GetPrefSize(nsIBox *, nsBoxLayoutState &, nsSize &)':
167: warning: unused variable `class nsGridRow * row'
179: warning: unused variable `class nsGridRow * row'
 In method `nsresult nsGridLayout2::GetMaxSize(nsIBox *, nsBoxLayoutState &, nsSize &)':
213: warning: unused variable `class nsGridRow * row'
226: warning: unused variable `class nsGridRow * row'

/mnt/ibm/mozhack/mozilla/layout/xul/base/src/grid/nsGridRowGroupLayout.cpp:
 In method `nsresult nsGridRowGroupLayout::GetPrefSize(nsIBox *, nsBoxLayoutState &, nsSize &)':
126: warning: unused variable `class nsGridRow * column'
 In method `nsresult nsGridRowGroupLayout::GetMaxSize(nsIBox *, nsBoxLayoutState &, nsSize &)':
154: warning: unused variable `class nsGridRow * column'
 In method `nsresult nsGridRowGroupLayout::GetMinSize(nsIBox *, nsBoxLayoutState &, nsSize &)':
183: warning: unused variable `class nsGridRow * column'
 In method `nsresult nsGridRowGroupLayout::DirtyRows(nsIBox *, nsBoxLayoutState &)':
206: warning: unused variable `PRInt32 rowCount'
 In method `nsresult nsGridRowGroupLayout::CountRowsColumns(nsIBox *, PRInt32 &, PRInt32 &)':
240: warning: unused variable `PRInt32 rowCount'

Comment 1

[timeless]

Attachment: Optimize away mostly useless code - hopefully

Comment 2

[timeless]

Comment on attachment 123243 [details] [diff] [review]
Optimize away mostly useless code - hopefully

I have no idea who owns this code...

Comment 3

[Jan Varga [:janv]]

Comment on attachment 123243 [details] [diff] [review]
Optimize away mostly useless code - hopefully

r=varga on those unused variables, but I'm not sure if RebuildIfNeeded() is
really needed

Comment 4

[jag (Peter Annema)]

To fix this bug, just get rid of the unused variables. If the RebuildIsNeeded
really needs to be added, file a bug on it and explain why.

Comment 5

[timeless]

Ok, it turns out that RebuildIfNeeded() is called by the functions i didn't
remove so i don't need to add it. So I will commit without their addition.

Note that the core of this change is removing the function calls because
they're very expensive NOPs. I put in the RebuildIfNeeded calls because i
it was the only part of the functions i was removing which might change things.

Comment 6

[timeless]

checked in