205692 - gint nsFreeTypeXImageSBC::GetWidth, nsFreeTypeXImageSBC::DrawString return nsresults for a failure state

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[timeless]

Tru64 compiler warnings in bug 196062 comment 25
 885 gint
 886 nsFreeTypeXImageSBC::GetWidth(const PRUnichar* aString, PRUint32 aLength)
 898     return NS_ERROR_FAILURE;
 cxx: Warning: nsFontFreeType.cpp, line 897: integer conversion resulted in a
           change of sign
The caller doesn't check for negative/0/error values:
 1480 void nsFontMetricsGTK::RealizeFont()
 1515     mSpaceWidth = NSToCoordRound(ft->GetWidth(&space, 1) * f);
 1518     mAveCharWidth = NSToCoordRound(ft->GetWidth(&averageX, 1) * f);

similar code is present in the Xlib port too.

 917 gint
 918 nsFreeTypeXImageSBC::DrawString(
...)
 933     return NS_ERROR_FAILURE;
 cxx: Warning: nsFontFreeType.cpp, line 932: integer conversion resulted in a
           change of sign

Comment 1

[timeless]

Attachment: use 0 for errors

Comment 2

[rbs]

Comment on attachment 123305 [details] [diff] [review]
use 0 for errors

r+sr=rbs

Comment 3

[timeless]

.

Comment 4

[timeless]

checked in