205709 - javascript script warning in abDragDrop.js

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Warning: redeclaration of var i
Source File: chrome://messenger/content/addressbook/abDragDrop.js
Line: 163, Column: 15
Source Code:
      for (var i=0;i<numrows;i++) {

the local variable i is already declared in:

111       for (var i = 0; i < dragSession.numDropItems; i++) {

and since JS is function-scoped for locals declared with the var keyword, we can
just drop the declaration in line 163.  patch coming up.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch

Comment 2

[Cavin Song]

Comment on attachment 123316 [details] [diff] [review]
Patch

Seems like this change will affect/alter the control var 'i' in the top level
for loop (ie, line 111) right?

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

But we can't be in two loops at the same time, can we?

And both times, i is initialized back to 0 in each loop.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 123316 [details] [diff] [review]
Patch

until I get a clue about scope inside of iterating |for| loops...

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 123316 [details] [diff] [review]
Patch

I'd prefer that we just rename this inner, shadowed, i to j.

Comment 6

[Steve Chapel]

Attachment: recommended patch

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Reassigning.

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 125624 [details] [diff] [review]
recommended patch

r=stephend, assuming you've tested, as well

Comment 9

[Steve Chapel]

timeless checked this in.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2004-09-15-12 on Windows XP, Seamonkey trunk.