205761 - A GIF image cannot be displayed

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[John Ky]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507

When viewing the GIF image, I instead get the following text:

The image "http://zhongwen.com/s/y508-1.gif" cannot be displayed because it
contains errors.


Reproducible: Always

Steps to Reproduce:
Open the the URL "http://zhongwen.com/s/y508-1.gif".
Actual Results:  
The text:

The image "http://zhongwen.com/s/y508-1.gif" cannot be displayed because it
contains errors.

appears

Expected Results:  
Internet Explorer is able to view the image.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

->ImageLib

Comment 2

[Adam Hauner]

Opera and IrfanView are able to open and display, ULead GIF Animator doesn't
support this format and Adobe PhotoShop 7 hangs while opening.

Comment 3

[Jim Dunn]

gif decoder is failing in GIF2.cpp, line 365

      /* Check for a code not defined in the dictionary yet. */
      if (code > avail)
        return -1;

code is 0x500
and avail is 0x452

Comment 4

[tor]

Attachment: tweak lzw decoder

Looking through a number of other gif decoder implementations (gimp,
gtk+, ImageMagick), we seem to be interpreting a code that isn't in
the dictionary differently.  We were treating it as an error, while
others use it as the firstcar condition.  (Hunk 1)

Patch also removes some redundant code2 logic and changes the loop
condition of the while loop to match other decoders.  (Hunk 2&3)

Comment 5

[tor]

Reassign -> tor

Comment 6

[Tech]

I have the same problem, check out my site www.galaxyinteractive.net, it works
in i.e. and on my linux moz browser 1.2.1(gecko20030225)

Comment 7

[tor]

*** Bug 222950 has been marked as a duplicate of this bug. ***

Comment 8

[ArronM (:paper)]

Comment on attachment 130364 [details] [diff] [review]
tweak lzw decoder

r=paper

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 130364 [details] [diff] [review]
tweak lzw decoder

a=asa (on behalf of drivers) for checkin to 1.6alpha

Comment 10

[tor]

Checked in.