205980 - mozipcd.exe fails to initialize modules if launched from command line

Status: RESOLVED FIXED

(Core :: IPC, defect, P3)

Description

[Darin Fisher]

mozipcd.exe fails to initialize modules if launched from command line.

steps to reproduce:

C:\> cd \path\to\mozilla\dist\bin
C:\path\to\mozilla\dist\bin\> mozipcd.exe

running as .\mozipcd.exe works or specifying any other relative path or the full
path works.  the problem is that ipcdWin.cpp looks at argv[0] to determine the
location of the executable.  it looks for modules relative to the executable.

this is not a major bug since the client IPC code always launches the daemon
with a full file path.

another related issue is that we should be using WinMain for release builds
instead of main.  this is related because it changes how we get at the path of
the executable.

Comment 1

[Darin Fisher]

i'm not going to get a chance to work on this because i'm going on vacation now,
but it seems like something that would be trivial to fix... just need to replace
main() with WinMain() in optimized builds (see ipcdWin.cpp) and fixup the
command line handling a bit.

conrad, john: either of you interested in taking this for 1.4 final?

Comment 2

[Darin Fisher]

Attachment: v1 patch

simple patch to make use of GetModuleFileName instead of argv.	also, this
patch makes it so the console is disabled in non-debug builds.

Comment 3

[Conrad Carlen (not reading bugmail)]

Comment on attachment 126279 [details] [diff] [review]
v1 patch

r=ccarlen

Comment 4

[Alec Flett]

Comment on attachment 126279 [details] [diff] [review]
v1 patch

I think you can check for MOZ_WINCONSOLE as well, to decide if you need a
WinMain - its supposed to be used to force a console in optimized builds (which
you might find useful for debugging mozipcd!)

sr=alecf with or without the MOZ_WINCONSOLE stuff

Comment 5

[Darin Fisher]

fixed-on-trunk