206203 - [cookies] doesn't log in automatically [aviary branch only]

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[David Winograd]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030517
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030517

When I first login giving my username and password, I click on the button where
it will remember these settings.  They don't get remembered as they do i IE.
What happens is  that I go back to the main page, need to click on 'login' and
when I do I find my username and password already filled in. This wastes a step.

Reproducible: Always

Steps to Reproduce:
1.get an account at Audible.com. Login using the pw and username.
2.click on the button where it remembers your settings.
3.log out and log back in.Your settings won't be remembered

Actual Results:  
logged back in.

Expected Results:  
passed the cookie so I wouldn't have seen the login screen

Comment 1

[Greg K.]

David, did you choose to block any cookies from this site? What are your
settings in Preferences/Privacy & Security/Cookies?

To be certain, try reproducing the problem using a new Mozilla user profile
without modifying any cookie settings.

Comment 2

[[e-mail]]

we need more details here.

so, if you log in the first time, the password manager dialog pops up asking
whether you want to remember your login for this site. i presume that's the
dialog you were referring to?

this _only_ controls prefilling your login/username - it won't log in
automatically for you. the login state is saved using cookies. when you log out,
the site removes those cookies. this is intentional behavior; otherwise, you'd
never be able to log out.

so, when you say:
3.log out and log back in.Your settings won't be remembered
i take it by "your settings won't be remembered" that you really mean "the login
doesn't occur automatically when i visit the site"?

if that's the case, i don't see the bug. please clarify ;)

(i'm also not sure what you mean by 'they get remembered with IE', more specific
details would be good)

Comment 3

[[e-mail]]

changing summary.

Comment 4

[benc]

Go to this page:

http://www.mozilla.org/quality/networking/testing/cookies/jscookietest.html

If your permissions are correct, it will say "javascript can read cookies"
"javascript can write cookies"

Comment 5

[RogerWilco]

Gecko/20040424 but the same is true for your 5/13 build which has big cgi site
problems so I can't use it at all. Mac 10.3.3...

Morningstar Premium, Comcast, Compuserve and more: unable to retrieve my cookie
log-in info. Hewlett-Packard unable to let me check out from store, claiming
there's a problem with my cookies. I dare say! Many other sites work fine.

Comment 6

[RogerWilco]

(In reply to comment #5)
> Gecko/20040424 but the same is true for your 5/13 build which has big cgi site
> problems so I can't use it at all. Mac 10.3.3...
> 
> Morningstar Premium, Comcast, Compuserve and more: unable to retrieve my cookie
> log-in info. Hewlett-Packard unable to let me check out from store, claiming
> there's a problem with my cookies. I dare say! Many other sites work fine.
> 
> 
Also, the javascript cookies test page, above, says the browser can read/write
cookies fine. Permissions are fine.

Comment 7

[RogerWilco]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a1) Gecko/20040520
Mac OS 10.3.3

Just tried again using the new Moz, new profile. Same problems.

Comment 8

[Jay Cee]

Hi,
Linux Slackware 10 on Athlon XP 2600+

WFM with 9.0.3 but I have the problem with recent nigthlies built from Aviary. 
Options are set to accept cookies from every site, and to keep it until they
expire. Firefox keep them during current session, but delete them each time a
restart it. In fact it delete all cookies.


Here's my mozconfig. I've already tried to remove optimization, that's not the
source of the problem

 . $topsrcdir/browser/config/mozconfig

ac_add_options --enable-shared
ac_add_options --disable-static
ac_add_options --disable-static-component-loader

ac_add_options --disable-accessibility
ac_add_options --disable-calendar
ac_add_options --disable-composer
ac_add_options --disable-debug
ac_add_options --disable-installer
ac_add_options --disable-jsd
ac_add_options --disable-ldap
ac_add_options --disable-mailnews
ac_add_options --disable-tests
ac_add_options --enable-strip
ac_add_options --enable-strip-libs
ac_add_options --enable-toolkit-gtk2
ac_add_options --enable-default-toolkit=gtk2 
ac_add_options --disable-toolkit-gtk
ac_add_options --disable-toolkit-qt
ac_add_options --disable-toolkit-xlib
ac_add_options --enable-xft
ac_add_options --enable-xsl
ac_add_options --enable-crypto
ac_add_options --enable-ipv6
ac_add_options --disable-activex

# SVG
mk_add_options MOZ_INTERNAL_LIBART_LGPL=1
MOZ_INTERNAL_LIBART_LGPL=1
ac_add_options --enable-svg
ac_add_options --enable-svg-renderer-libart

#Athlon XP
ac_add_options --enable-optimize="-march=athlon-xp -mmmx -m3dnow -ffloat-store
-fforce-addr -ftracer -Os -mfpmath=387"

Comment 9

[Darin Fisher]

With a fresh aviary branch build and no profile, I also experienced cookie loss.
 It appears as if cookies.txt simply doesn't get written unless it already
exists.  simply creating an empty file named cookies.txt in the profile
directory solved the problem for me.

Comment 10

[Darin Fisher]

Attachment: v1 patch

Comment 11

[Jay Cee]

(In reply to comment #9)
> With a fresh aviary branch build and no profile, I also experienced cookie loss.
>  It appears as if cookies.txt simply doesn't get written unless it already
> exists.  simply creating an empty file named cookies.txt in the profile
> directory solved the problem for me.

Yep, problem solved.
Thanx ! :x

Comment 12

[Darin Fisher]

This bug affects the Aviary 1.0 branch only.  Apparently, this tweak was landed
on the trunk but not on the branch.

Comment 13

[Darin Fisher]

Comment on attachment 155734 [details] [diff] [review]
v1 patch

requesting approval to land this fix on the aviary 1.0 branch.	this patch
makes the code on the aviary 1.0 branch match the mozilla trunk.  it is a very
low-risk fix.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 155734 [details] [diff] [review]
v1 patch

a=me

Comment 15

[Darin Fisher]

fixed-aviary1.0