Closed
Bug 206204
Opened 22 years ago
Closed 22 years ago
`nsHTMLTag gWatchTags[3]', nsEditorParserObserver defined but not used
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file, 1 obsolete file)
|
1.42 KB,
patch
|
Brade
:
review+
sfraser_bugs
:
superreview+
dbaron
:
approval1.4+
|
Details | Diff | Splinter Review |
26. editor/composer/src/nsEditingSession.cpp:274 (See build log excerpt)
`nsHTMLTag gWatchTags[3]' defined but not used
272 // but hopefully we will be able to soon.
273 #ifndef FULL_EDITOR_HTML_SUPPORT
274 static eHTMLTags gWatchTags[] =
275 { eHTMLTag_frameset,
276 eHTMLTag_iframe,
Attachment #123652 -
Flags: superreview?(sfraser)
Attachment #123652 -
Flags: review?(brade)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 123652 [details] [diff] [review]
remove it, since it doesn't appear to have ever been used
please remove the FULL_EDITOR_HTML_SUPPORT #ifs altogether or fix them to not
be turned on.
Attachment #123652 -
Flags: superreview?(sfraser)
Attachment #123652 -
Flags: review?(brade)
Attachment #123652 -
Flags: review-
Status: NEW → ASSIGNED
Summary: `nsHTMLTag gWatchTags[3]' defined but not used → `nsHTMLTag gWatchTags[3]', nsEditorParserObserver defined but not used
Attachment #123652 -
Attachment is obsolete: true
Attachment #123691 -
Flags: superreview?(sfraser)
Attachment #123691 -
Flags: review?(brade)
|
||
Comment 4•22 years ago
|
||
Comment on attachment 123691 [details] [diff] [review]
Remove gWatchTags, nsEditorParserObserver, ifndef FULL_EDITOR_HTML_SUPPORT
how about a diff -u4 next time.
Attachment #123691 -
Flags: superreview?(sfraser) → superreview+
|
|
||
Updated•22 years ago
|
Attachment #123691 -
Flags: review?(brade) → review+
Comment on attachment 123691 [details] [diff] [review]
Remove gWatchTags, nsEditorParserObserver, ifndef FULL_EDITOR_HTML_SUPPORT
Free code savings
Attachment #123691 -
Flags: approval1.4?
|
||
Comment 6•22 years ago
|
||
Are you going to remove nsEditorParserObserver files as well?
Attachment #123691 -
Flags: approval1.4? → approval1.4+
checked in, without removing the files. they can be removed later if the editor
team decides that they have no future.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 8•22 years ago
|
||
I have no way to verify this one since I'm not running BeOS. Timeless, could you
please mark this as verified fixed ?
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•