206338 - Improve txStack

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

txStack could be improved wrt speed. First of all we should mark all functions
as inline. Second we should not be calling non-inlined functions in nsVoidArray
when all they do is to call some other function, AppendElement is one example of
this. Third we should look into removing the empty-stack-safety-check in pop()
and peek(), and add it in the few places where the stack might be empty.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Turns out there was only one place where we called peek() without knowing that
the stack is non-empty.

Comment 2

[Axel Hecht]

Comment on attachment 123990 [details] [diff] [review]
Patch to fix

r=[e-mail]. looks good to me. templatizing would be another patch, I
guess. Yac another "touch everything". :-(

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 123990 [details] [diff] [review]
Patch to fix

Please post some code bloat numbers before checking this in.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I didn't see any difference in compilesize with this. This probably means that
the difference is smaller then the alingments that occurs between different
blocks of code.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in