Closed
Bug 206470
Opened 21 years ago
Closed 21 years ago
editing text files shouldn't have HTML features in menus
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
1.49 KB,
patch
|
Brade
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030519 Steps: 1. load a plain text file (text/plain, e.g. a bugzilla patch) 2. select file>edit page 3. try examine the menubar Here's my list: File Export to Text... Browse Page Edit Paste without Formatting *1 View Show/Hide Format Toolbar Edit Mode Toolbar Normal Edit Mode HTML Tags HTML Source Preview 4. Look at the status bar, notice that it has glazou's html tag thingy, this should be removed too. *1 this feature could be useful if Paste actually pasted *with* formatting
Updated•21 years ago
|
OS: Windows 2000 → All
Hardware: PC → All
Summary: Plaintext editor shouldn't have HTML features → [plaintext] Plaintext editor shouldn't have HTML features
Comment 1•21 years ago
|
||
I'm guessing we're just missing some checks for "!isHTML" (or whatever function we have for this) for these menu items but maybe the mimetype isn't propagating back properly or something.
Summary: [plaintext] Plaintext editor shouldn't have HTML features → editing text files shouldn't have HTML features
Attachment #124168 -
Flags: superreview?(sfraser)
Attachment #124168 -
Flags: review?(brade)
Updated•21 years ago
|
Attachment #124168 -
Flags: review?(brade) → review+
Comment 3•21 years ago
|
||
Comment on attachment 124168 [details] [diff] [review] hide them + HideItem("cmd_viewFormatToolbar", false); + HideItem("cmd_viewEditModeToolbar", false); That shouldn't have a second parameter. sr=jag with that fixed.
Attachment #124168 -
Flags: superreview?(sfraser) → superreview+
Comment 4•21 years ago
|
||
Comment on attachment 124168 [details] [diff] [review] hide them looks good to me
Attachment #124168 -
Flags: superreview+
checked in. I'll solve the statusbar item later.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Summary: editing text files shouldn't have HTML features → editing text files shouldn't have HTML features in menus
Comment 6•21 years ago
|
||
Verified in the 2003-05-29-08 Macho and Win32 trunk builds.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•