206472 - "Bookmark This Link" does not create bookmark

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Phil Pishioneri]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030507
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030507

While viewing a piece of mail or news article, selecting "Bookmark This Link"
from the context pop up menu does not work.

No bookmark is created.  An error is logged in the JavaScript Console:

Error: BMSVC has no properties
Source File: chrome://communicator/content/bookmarks/bookmarks.js
Line: 1547


Reproducible: Always

Steps to Reproduce:

Comment 1

[Stefan Borggraefe]

Confirming with build 2003052004 and Windows XP.

The Bookmark Service is not initialized when the command for the context menu
item is executed.

I made a patch that does this initialization every time when oncommand for this
menu item occurs. This fixes the bug but since I'm not very experienced with
hacking Mozilla there might be a better way to fix it. I'll attach my patch in a
second.

Comment 2

[Stefan Borggraefe]

Attachment: Fix

See comment #1.

Comment 3

[Dimitrios]

I think it shouldn't slip our attention at 1.4 because it exposes a non working
feature. Anyway, there is already a patch. Is it possible for this to get a review?

Comment 4

[John Pye]

Bug still apparent in Mozilla 1.4, Windows version.

Comment 5

[Gervase Markham [:gerv]]

stefan: can you chase reviews for this patch?

Gerv

Comment 6

[Jan Varga [:janv]]

Comment on attachment 123807 [details] [diff] [review]
Fix

looks good

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 123807 [details] [diff] [review]
Fix

sr=bzbarsky

Comment 8

[Stefan Borggraefe]

Comment on attachment 123807 [details] [diff] [review]
Fix

Asking for approval for 1.4.1 and 1.5. If it's to late for 1.4.1, please
consider this for 1.4.2.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 123807 [details] [diff] [review]
Fix

a=asa (on behalf of drivers) for checkin to Mozilla 1.5

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

trunk checkin done
Checking in mailWindowOverlay.xul;
/cvsroot/mozilla/mailnews/base/resources/content/mailWindowOverlay.xul,v  <-- 
mailWindowOverlay.xul
new revision: 1.254; previous revision: 1.253
done

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 123807 [details] [diff] [review]
Fix

too late for 1.4.1. if you'd like to see this in the next 1.4.x release please
set the approval1.4.2? flag.

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 123807 [details] [diff] [review]
Fix

a=mkaply for 1.4.2

Comment 13

[Mike Kowalski]

fixed on 1.4.x branch.