Closed
Bug 206934
Opened 21 years ago
Closed 21 years ago
Mozilla should use __declspec, not _declspec
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.5alpha
People
(Reporter: netscape, Assigned: dmosedale)
References
Details
Attachments
(2 files)
|
7.42 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
610 bytes,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
MSVC will accept either __declspec or _declspec but gcc only accepts the former. Right now, NSPR defines _declspec for gcc builds but that will change when bug 202826 lands.
|
||
Comment 1•21 years ago
|
||
__declspec is the documented form, so it is also more correct than _declspec.
|
Reporter | |
Comment 2•21 years ago
|
||
|
|
Reporter | |
Comment 3•21 years ago
|
||
|
|
Reporter | |
Updated•21 years ago
|
Attachment #124120 -
Flags: review?(wtc)
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 124120 [details] [diff] [review] nss v1.0 r=wtc. I'm wondering why this didn't break the Win32 mingw build.
Attachment #124120 -
Flags: review?(wtc) → review+
|
|
Reporter | |
Comment 5•21 years ago
|
||
The use of _declspec didn't break the mingw builds because we added that _declspec define to prtypes.h when the original mingw port was done. The patch in bug 202826 removes that define so all of the other places which used _declspec must be changed.
|
|
Reporter | |
Updated•21 years ago
|
Attachment #124119 -
Flags: review?(dougt)
|
||
Updated•21 years ago
|
Attachment #124119 -
Flags: review?(dougt) → review+
|
|
Reporter | |
Comment 6•21 years ago
|
||
The patches have been checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.5alpha
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•