Closed
Bug 207023
Opened 22 years ago
Closed 22 years ago
unused code in mozilla/widget/src/[cocoa,mac]
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
|
9.78 KB,
patch
|
mikepinkerton
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•22 years ago
|
||
remove nsRegionMac from the widget build, and remove nsWidgetSupport.cpp.
|
|
Assignee | |
Updated•22 years ago
|
Attachment #124160 -
Flags: superreview?(sfraser)
Attachment #124160 -
Flags: review?(pinkerton)
|
||
Comment 2•22 years ago
|
||
I'm a bit surprised that we don't use nsRegionMac for Cocoa.
|
|
||
Comment 3•22 years ago
|
||
Comment on attachment 124160 [details] [diff] [review]
patch
r=pink
what implements nsIRegion if we don't build nsRegionMac?
Attachment #124160 -
Flags: review?(pinkerton) → review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
The only place where nsIRegion is used in the cocoa code is via
nsIWidget::InvalidateRegion(), which gets an nsIRegion pointer passed to it. No
need to have the implementation in the widget library. Similar story for the
carbon code.
|
|
||
Updated•22 years ago
|
Attachment #124160 -
Flags: superreview?(sfraser) → superreview+
|
|
Assignee | |
Comment 5•22 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•