Closed Bug 207182 Opened 22 years ago Closed 21 years ago

Use nsScriptableUnicodeConverter::Finish()

Categories

(Other Applications :: ChatZilla, defect)

Product:
Other Applications
Component:
ChatZilla
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kazhik, Assigned: rginda)

References

Details

(Whiteboard: cz-patch)

Attachments

(1 file, 1 obsolete file)

patch
517 bytes, patch
rginda
: review+
Details | Diff | Splinter Review
nsScriptableUnicodeConverter::Finish() isn't used in Chatzilla, because it doesn't work in <= mozilla 1.2. But we can ignore the old versions after the release of mozilla 1.4, which is declared to "replace the 1.0 branch as the stable development path".
Attached patch patch v1 (obsolete) — — Splinter Review
Attachment #124243 - Flags: review?(rginda)
Comment on attachment 124243 [details] [diff] [review] patch v1 I'm not ready to drop support for old mozilla's yet. If we're going to do this it has to work on 1.0 and up.
Attachment #124243 - Flags: review?(rginda) → review-
Status: NEW → ASSIGNED
Depends on: 210744
The chatzilla 0.9.x branch has landed on the trunk and should be available in tomorrow's nightly build. If you believe this bug has not actually been fixed, please repoen it.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Attached patch patch — — Splinter Review
The current code uses Finish() in wrong way.
Attachment #124243 - Attachment is obsolete: true
reopen.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #131779 - Flags: review?(rginda)
Whiteboard: cz-patch
Comment on attachment 131779 [details] [diff] [review] patch r=rginda
Attachment #131779 - Flags: review?(rginda) → review+
fixed in 0.9.40
Status: REOPENED → RESOLVED
Closed: 22 years ago → 21 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: