Closed
Bug 207221
Opened 22 years ago
Closed 22 years ago
Autocomplete URL in [Image/]Link Properties dialog
Categories
(SeaMonkey :: Composer, enhancement)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.6alpha
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
3.00 KB,
patch
|
Brade
:
review+
rbs
:
superreview+
|
Details | Diff | Splinter Review |
As per e.g. Open Location dialog
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 124281 [details] [diff] [review]
Proposed patch
Sorry, you drew the short straw :-)
Attachment #124281 -
Flags: review?(brade)
|
||
Comment 4•22 years ago
|
||
Comment on attachment 124281 [details] [diff] [review]
Proposed patch
in createMenuItem, I'd feel more comfortable if you checked if (menuitem)
before calling setAttribute and appendChild in case createElement fails (or
will that automatically throw an error? I forget at the moment)
r=brade
Attachment #124281 -
Flags: review?(brade) → review+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Comment on attachment 124281 [details] [diff] [review]
Proposed patch
brade: createElement is supposed to throw on failure but I could rewrite the
patch to add checks.
Attachment #124281 -
Flags: superreview?(rbs)
Attachment #124281 -
Flags: superreview?(rbs) → superreview+
|
|
Assignee | |
Updated•22 years ago
|
Target Milestone: --- → mozilla1.6alpha
|
|
Assignee | |
Comment 6•22 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 7•22 years ago
|
||
Verified FIXED using build 2003-09-17-04 on Windows 2000.
I checked both the Image link properties and the normal link properties.
Worked for both remote and local URLs.
Status: RESOLVED → VERIFIED
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•