Closed Bug 207243 Opened 21 years ago Closed 21 years ago

-moz-image-region dimensions for spelling button are wrong

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: fixed1.4.2)

Attachments

(6 files)

All the other classic buttons are 16x16px but the spelling button isn't.
-->neil
Assignee: composer → neil.parkwaycc.co.uk
Attached image Proposed btn1.gif
Attached patch Proposed patchSplinter Review
Attachment #124534 - Flags: review+
Attachment #124533 - Flags: review+
Attachment #124533 - Flags: superreview?(kin)
Attachment #124534 - Flags: superreview?(kin)
Comment on attachment 124533 [details]
Proposed btn1.gif

sr=kin@netscape.com
Attachment #124533 - Flags: superreview?(kin) → superreview+
Comment on attachment 124534 [details] [diff] [review]
Proposed patch

sr=kin@netscape.com
Attachment #124534 - Flags: superreview?(kin) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Cool, no more offset issue. Verified in 2003-06-03-08 Macho and 2003-06-03-08
Win32 trunk builds under the classic theme. This would be nice to have this for
branch..
Status: RESOLVED → VERIFIED
Neil, the spell check icon is now too small in messenger ompose. It is not the
same height as the rest of the main toolbar icons.

Maybe we need a separate instance of this icon for the mail use of it?

re-opening because this regressed the look of mail compose.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
An alternative is to replace the #spellingButton styles in messengercompose.css
with the ones below:


#spellingButton {
  list-style-image: url("chrome://editor/skin/icons/btn1.gif");
  -moz-image-region: rect(96px 16px 112px 0);
}

#spellingButton > .toolbarbutton-icon {
  padding: 3px 0px 2px 4px;
}

#spellingButton:hover {
  -moz-image-region: rect(96px 32px 112px 16px);
}

#spellingButton:hover:active {
  -moz-image-region: rect(96px 48px 112px 32px);
}

#spellingButton[disabled="true"] {
  -moz-image-region: rect(96px 64px 112px 48px) !important;
}
thanks Patrick. As a temporary work around for thunderbird, I've gone ahead and
added your suggested CSS to messengercompose.css
Scott, I'm glad I could be of some help.

Now, I've attached a replacement for messenger/icons/btn1.gif which adds the
Spelling icon at the bottom. One added feature is that I was able to add a
similar shadow to it to be more consistent with the other icons.

Below are the replacement #spellingButton stylesheet changes to
messengercompose.css:

#spellingButton {
  -moz-image-region: rect(378px 23px 399px 0px);
}

#spellingButton:hover {
  -moz-image-region: rect(378px 46px 399px 23px);
}

#spellingButton:hover:active {
  -moz-image-region: rect(378px 69px 399px 46px);
}

#spellingButton[disabled="true"] {
  -moz-image-region: rect(378px 92px 399px 69px) !important;
}
Per Neil's recommendations, this attachment uses the icons from Communicator's
Compose. The CSS remains the same as from my last post.
Attachment #124993 - Flags: superreview?(sspitzer)
Attachment #124993 - Flags: review?(mscott)
Attachment #124912 - Flags: superreview?(sspitzer)
Attachment #124912 - Flags: review?(mscott)
I just compiled 1.5a and 1.5b binaries for the app suite and the classic skin
icon in the is off, it looks quite ugly.

Has this change been tested? 

Do you think you could land the messengercompose.css changes before 1.5a ships? 
Flags: blocking1.5a?
BTW this is the umpteenth time I'm firefighting spell checker horkage, *sigh*.
1.5a released. unsetting request. 
Flags: blocking1.5a? → blocking1.5b?
Attachment #124912 - Flags: review?(mscott) → review+
Attachment #124993 - Flags: review?(mscott) → review+
*** Bug 214254 has been marked as a duplicate of this bug. ***
Comment on attachment 124912 [details]
Replacement #2 for messenger/icons/btn1.gif

sr=bz via IRC
Attachment #124912 - Flags: superreview?(sspitzer) → superreview+
Comment on attachment 124993 [details] [diff] [review]
Proposed messengercompose patch

sr=bz via irc
Attachment #124993 - Flags: superreview?(sspitzer) → superreview+
Flags: blocking1.5b? → blocking1.5b+
*** Bug 215253 has been marked as a duplicate of this bug. ***
*** Bug 215836 has been marked as a duplicate of this bug. ***
Comment on attachment 124912 [details]
Replacement #2 for messenger/icons/btn1.gif

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.
Attachment #124912 - Flags: approval1.5b+
Comment on attachment 124993 [details] [diff] [review]
Proposed messengercompose patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.
Attachment #124993 - Flags: approval1.5b+
Fix checked in.
Status: REOPENED → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
Lets get this in 1.4.2
Flags: blocking1.4.2+
mkaply--did anyone land this for 1.4.2?
Nope, I will do that.
Checked in to 1.4.2
Keywords: fixed1.4.2
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: