207260 - OS X: cmd+shift+M should open mail compose

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[sairuh (rarely reading bugmail)]

on OS X, cmd+M should minimize window, cmd+shift+M should open mail compose. now
cmd+M brings up the mail compose window.

this worked fine in 2003.05.22.08; it's now broken since 2003.05.23.06. (tested
with commercial trunk (pre-branch).)

Comment 1

[sairuh (rarely reading bugmail)]

could the fix for bug 205055 be the cause for this, or was it something else?

over email shuehan said that she'll look into this, so over to her.

Comment 2

[shliang]

Attachment: patch

Comment 3

[Kathleen :Brade]

Comment on attachment 124306 [details] [diff] [review]
patch

what caused this regression?  Why is the fix to add a new file?
Why are we duplicating platformMailOverlay?

Comment 4

[shliang]

Attachment: patch

Comment 5

[Kathleen :Brade]

Comment on attachment 124308 [details] [diff] [review]
patch

I still don't understand what caused this regression?  I see only lines added
here; nothing removed.

Comment 6

[shliang]

(hopefully this makes some sense)
mailNavigatorOverlay was moved from mailnews to xpfe/browser so that nav-only
installs could do new message, send page, etc. the key for new message was
duplicated in mailNavigatorOverlay so that nav-only installs could have the
ctrl-m shortcut, which then overrode the key in platformMailOverlay. but
nav-only installs still need the overlay to change the shortcut on mac, so
that's why the new file is there. 

Comment 7

[sairuh (rarely reading bugmail)]

potentially related: bug 207291.

Comment 8

[sairuh (rarely reading bugmail)]

side note: from other non-browser windows, cmd+shift+M is listed in the menus
and does work.

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 124308 [details] [diff] [review]
patch

talked it over with shuehan, over aim, and this needs a little bit of cleanup,
and there are some old unused overlays in mozilla/mailnews that can now be
removed, too.

Comment 10

[(not reading, please use [e-mail] instead)]

since this is a regression, and a fix is nearly in hand, and it's bad for mac
users, I agree with sarah, block 1.4.

not that we couldn't ship with this, but I'd rather we didn't.

it won't hold up the release, but I'd rather it get on the radar so we don't
accidentally ship without fixing it.

should happen for 1.4 final.

Comment 11

[sairuh (rarely reading bugmail)]

just a side note: cmd+M on OS X never worked to minimize windows (see bug
137523), but at least with this fixed it will be available when 137523 is fixed.

Comment 12

[shliang]

Attachment: patch

Comment 13

[Kathleen :Brade]

Comment on attachment 124480 [details] [diff] [review]
patch

does the shortcut key work in Composer? NIM?
don't you want to cvs remove some files?

Comment 14

[shliang]

the shortcut key works in the other windows

i thought i did cvs remove already?

Comment 15

[jag (Peter Annema)]

Comment on attachment 124480 [details] [diff] [review]
patch

Looks like the cvs removal is in the patch.

Comment 16

[shliang]

Attachment: patch

Comment 17

[jag (Peter Annema)]

Comment on attachment 124519 [details] [diff] [review]
patch

r=jag

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 124519 [details] [diff] [review]
patch

sr=sspitzer

please land this on the trunk only, for now.

once verified (for stand alone browser and the full app suite), we can take on
the branch.

Comment 19

[shliang]

checked in

Comment 20

[sairuh (rarely reading bugmail)]

tested cmd+shift+M by checking the File menu item in various windows (browser,
mailnews 3pane, mailnews standalone, mail compose, editor, addressbook) and
using the shortcut itself.

a. with 2003.05.30.08-trunk on OS X (10.2.6), it's fine in all windows *except*
the addressbook.

b. with 2003.05.30.08-trunk *full installation* on win2k, this is fine. (ctrl+M
is the accelerator here.)

c. with 2003.05.30.08-trunk *navigator-only installation* on win2k, ctrl+M only
appears and works in the the navigator window --not in the editor window.

because of (a), i'm reopening this --the OS X build i have before this patch
checked in (2003.05.23-trunk) is actually fine. in 2003.05.23-trunk, cmd+shift+M
appears and works in the addressbook window.

Comment 21

[Samir Gehani]

adt: nsbeta1-

Comment 22

[shliang]

Attachment: fix addressbook shortcut

Comment 23

[sairuh (rarely reading bugmail)]

renominating, with a new fix in hand (attachment 124602 [details] [diff] [review]).

Comment 24

[Asa Dotzler [:asa]]

Comment on attachment 124519 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 25

[Samir Gehani]

adt: nsbeta1+/adt3

Comment 26

[Samir Gehani]

a=adt to land this on the 1.4 branch.

Comment 27

[shliang]

supplementary patch checked in on trunk

both patches checked in on branch

Comment 28

[Ninoschka Baca]

Trunk build 2003-06-06: Mac 10.1.5
Branch build 2003-06-06: Mac 10.1.5
Verified Fixed. 

Checked the menu item in all windows (browser, composer, address book, mail, new
message window, stand alone window). Also used cmd+shift+m and verified that a
new message window appears.