Closed
Bug 207306
Opened 23 years ago
Closed 21 years ago
plugin host should be destroyed on Observe() "NS_XPCOM_SHUTDOWN_OBSERVER_ID" rather than on "quit-application"
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterlubczynski-bugs, Assigned: Callek)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
1.29 KB,
patch
|
timeless
:
review-
|
Details | Diff | Splinter Review |
This bug comes from the review of the patch in bug 159445, comment #8 which says
that we should clean up cached services (i.e. the call to ::Destroy) on xpcom
shutdown (NS_XPCOM_SHUTDOWN_OBSERVER_ID) rather than
quit-application because it's a better-defined topic (i.e. its kind of a
frozen topic, rather than quit-application which may or may not fire in
embedded environments).
|
Assignee | |
Comment 1•21 years ago
|
||
Should the quit-application observation do anything after this bug is fixed,
also should destroy be called before or after the current XPCOM Shutdown call?
this object should not be registered for that notification as part of the fix
for this bug.
Assignee: peterlubczynski-bugs → 116057
|
|
Assignee | |
Comment 3•21 years ago
|
||
Attachment #178831 -
Flags: superreview?(jst)
Attachment #178831 -
Flags: review?(jst)
Comment on attachment 178831 [details] [diff] [review]
remove "quit-application"
don't register for the event :)
Attachment #178831 -
Flags: superreview?(jst)
Attachment #178831 -
Flags: review?(jst)
Attachment #178831 -
Flags: review-
|
|
Assignee | |
Comment 5•21 years ago
|
||
This actually removes the AddObserver for it as well.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #181065 -
Flags: superreview?(jst)
Attachment #181065 -
Flags: review?(jst)
|
||
Comment 6•21 years ago
|
||
Comment on attachment 181065 [details] [diff] [review]
remove "quit-application" [correctly]
r+sr=jst
Attachment #181065 -
Flags: superreview?(jst)
Attachment #181065 -
Flags: superreview+
Attachment #181065 -
Flags: review?(jst)
Attachment #181065 -
Flags: review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #181065 -
Flags: approval1.8b2?
|
||
Comment 7•21 years ago
|
||
Comment on attachment 181065 [details] [diff] [review]
remove "quit-application" [correctly]
a=asa
Attachment #181065 -
Flags: approval1.8b2? → approval1.8b2+
|
||
Updated•21 years ago
|
Summary: plugin host should be destoryed on Observe() "NS_XPCOM_SHUTDOWN_OBSERVER_ID" rarther than on "quit-application" → plugin host should be destroyed on Observe() "NS_XPCOM_SHUTDOWN_OBSERVER_ID" rarther than on "quit-application"
|
|
||
Updated•21 years ago
|
Summary: plugin host should be destroyed on Observe() "NS_XPCOM_SHUTDOWN_OBSERVER_ID" rarther than on "quit-application" → plugin host should be destroyed on Observe() "NS_XPCOM_SHUTDOWN_OBSERVER_ID" rather than on "quit-application"
Comment on attachment 181065 [details] [diff] [review]
remove "quit-application" [correctly]
2005-05-01 15:28:
mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp 1.524
Attachment #181065 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•