Closed
Bug 207329
Opened 22 years ago
Closed 22 years ago
profileSelection.js should .getService the directory service ...
Categories
(SeaMonkey :: Startup & Profiles, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
(Keywords: assertion)
Attachments
(1 file)
|
954 bytes,
patch
|
ccarlen
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
WARNING: You are calling CreateInstance "{f00152d0-b40b-11d3-8c9c-000064657374}"
when a service for this CID already exists!, file
i:/build/mozilla/xpcom/components/nsComponentManager.cpp, line 1962
0 [native frame]
1 StartUp() ["chrome://communicator/content/profile/profileSelection.js":67]
67 var dirServ =
Components.classes['@mozilla.org/file/directory_service;1'].createInstance();
68 dirServ = dirServ.QueryInterface(Components.interfaces.nsIProperties);
|
||
Comment 1•22 years ago
|
||
Eek, you're right. That would be good and easy to fix.
Attachment #124350 -
Flags: superreview?(tor)
Attachment #124350 -
Flags: review?(ccarlen)
|
|
||
Comment 3•22 years ago
|
||
Comment on attachment 124350 [details] [diff] [review]
fix
r=ccarlen. Thanks for catching this.
Attachment #124350 -
Flags: review?(ccarlen) → review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 124350 [details] [diff] [review]
fix
sr=jag
Actually, unless the way you have it is the style in that file, could you move
the '.' to before |getService| and align the '.'s?
Attachment #124350 -
Flags: superreview?(tor) → superreview+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•