207343 - Bug when adding bookmark via Drag & Drop. When sidebar is scrolling down and i cancel setting bookmark, mozilla crashes [@ TimerThread::AddTimerInternal ]

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Major]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0) Gecko/20020530
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0) Gecko/20020530

I got Mozilla 1.3.1 with the following extensions: Prefbar, Tab Extensions and
Home Button running on Win2000 SP3.
I wanted to bookmark a Tab in a specific Folder in the bookmark sidebar via Drag
and Drop. The correct folder was not visible, so i had to scroll down. I moved
the mouse to the lower border of the sidebar and the bookmarks started to scroll
down correctly.
Now i mentioned, that i didn´t have a folder for that bookmark. So i pressed ESC
to cancel.
Now the Problem: The sidebar didn´t stop scrolling down. After getting to the
end of my bookmarks i manually scrolled up, but it automatically began to scroll
down again. After that Mozilla crashed.
After restarting i tried to reproduce the bug and it worked everytime.

Reproducible: Always

Steps to Reproduce:
1. open any link in a new tab
2. left-click the Tab and drag it to the bookmark-sidebar (that must be long
enough to scroll down
3. when bookmarks are scrolling down, press ESC to cancel 

Actual Results:  
Mozilla continued scrolling and crashed

Expected Results:  
add bookmark ;)

Comment 1

[Jeff D. Hanson]

Confirming:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030527

I couldn't drag a tab but I did drag a page link and cause the same problem.  I
have seen this one before in 1.4b but I couldn't reproduce reliably until now. 
My previous encounters with it was while dragging bookmarks in the toolbar
bookmarks list.  The sidebar effect is that the list scrolls down during the
drag but if you cancel the list continues to scroll to the end.  If you click on
the sidebar's scrollbar and attempt to scroll up it does but then scrolls back
down when you let go.  If you close the window the browser crashes.  I submitted
Talkback crash data referencing bug report.

Comment 2

[Chris Petersen]

Ok, I am able to reproduce the continous scrolling in the sidebar after pressing
Esc key while dragging a url into bookmarks sidebar. After reproducing this
problem closing the browser window resulted in a crash. TB20700863. Tested under
both trunk and branch (06/03) builds

Comment 3

[Samir Gehani]

adt: nsbeta1-

Comment 4

[noririty]

Also occurs on Mozilla Firebird 0.6

Bumping up severity (because of crash)

Comment 5

[Anders Pedersen]

I am able to reproduce the continous scrolling in the sidebar after pressing
Esc key while dragging an url into bookmarks sidebar. To stop the scrolling I
have to hide/show the sidebar with F9. Haven't got the browser to crash because
of this behaviour though.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040330
Microsoft Windows 2000 Pro 5.00.2195 SP4

Comment 6

[Andreas Kunz]

I don't crash, only the moz process hangs around eternally after exit.

Anders, noririty, Major, jeff:
Can anyone of you reproduce this with a talkback-enabled 1.6 or 1.7b build?
(old talkback data is not available anymore)
Or crash a debug build and get the stack, of course...

That way we'll see if this is the same as bug 210719.

Comment 7

[Anders Pedersen]

Well.. here's an update.

Did the following:

1. Opened the bookmark sidebar.
2. Dragged an existing url from my bookmarks in the sidebar so the list starts
to scroll down, and it does so by itself.
3. Clicked F9 to close the sidebar while the list was scrolling, and doing it
once more to show it again, Mozilla crashes

talkbackid: TB10166X
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040331
Microsoft Windows 2000 Professional 5.00.2195 SP4

Comment 8

[Andreas Kunz]

Thanks! Now let's get the stack...

Comment 9

[Asa Dotzler [:asa]]

from talkback:
TimerThread::AddTimerInternal[/mozilla/xpcom/threads/TimerThread.cpp, line 365]
TimerThread::AddTimer[/mozilla/xpcom/threads/TimerThread.cpp, line 297]
nsTimerImpl::Fire[/mozilla/xpcom/threads/nsTimerImpl.cpp, line 410]
PL_HandleEvent[/mozilla/xpcom/threads/plevent.c, line 674]
PL_ProcessPendingEvents[/mozilla/xpcom/threads/plevent.c, line 612]
nsEventQueueImpl::ProcessPendingEvents[/mozilla/xpcom/threads/nsEventQueue.cpp,
line 395]
0x18a16457

Comment 10

[Andreas Kunz]

ummm... this stack looks odd.
The line in question only says: "return i;", while i is properly initialized.
Not sure how this can crash.

So if somebody else can also get a Talkback ID (or maybe another one from Anders
also does it)...

Comment 11

[Anders Pedersen]

New talkbackid: TB10273G

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040331
Microsoft Windows 2000 Professional 5.00.2195 SP4

Comment 12

[Andreas Kunz]

Bug 125301 is about ESC not triggering OnDragExit and this is the cause of this
bug as explained in bug 210719 comment #17.

Comment 13

[mark.fitzgerald2]

On Mozilla 1.6 (Win2k SP4), I get the infinite scrolling once drag has been
canceled by pressing 'Esc'.  The F9 workaround (#5) to stop scrolling works for
me.  However, the zombie mozilla.exe process problem does not occur for me (#6).

(This is related to bug 210719, which I filed, but it is not likely the same
bug, unless the linkage via bug 125301 noted by Andreas in bug 210719 comment
#17 ends up being the only underlying issue.)

Comment 14

[Asa Dotzler [:asa]]

From talkback:

0x00000001
TimerThread::AddTimerInternal [/mozilla/xpcom/threads/TimerThread.cpp, line 365]
TimerThread::AddTimer [/mozilla/xpcom/threads/TimerThread.cpp, line 297]
nsTimerImpl::Fire [/mozilla/xpcom/threads/nsTimerImpl.cpp, line 410]
PL_HandleEvent [/mozilla/xpcom/threads/plevent.c, line 674]
PL_ProcessPendingEvents [/mozilla/xpcom/threads/plevent.c, line 612]
nsEventQueueImpl::ProcessPendingEvents [/mozilla/xpcom/threads/nsEventQueue.cpp,
line 395]
0x18a16457

Comment 15

[Asa Dotzler [:asa]]

I can reproduce this with winXP on 1.7 beta. incident ID 13493

Comment 16

[Andreas Kunz]

Anders, noririty, Major, jeff:
A fix for bug 210719 was checked in and should also fix this bug here.

I can verify that my hang from comment #6 has gone away, but I could never
reproduce the crash, so could you please try with tomorrow's (May 14th or later)
trunk nightlies and comment here?
Thanks!

Comment 17

[Andreas Kunz]

Obviously nobody is still seeing this and talkback data of the past ten days
also does not show any incidents.
FIXED by bug bug 210719.

Comment 18

[Tracy Walker [:tracy]]

verified