207401 - Win32 compiler/linker option correction

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Steve Williams]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0)
Build Identifier: 

config/rules.mk specifies a linker flag to the compiler which is incorrect.

Patch attached to address the problem.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Steve Williams]

Attachment: Win32 compiler/linker option correction

Comment 2

[Steve Williams]

The /DEF command line switch is a linker option, not a compiler one.

The compiler interprets the incorrect switch as a define, which is surely not 
the intended behaviour.

Comment 3

[Steve Williams]

This is not an enhancement, its a bug that needs fixing. It needs adressing to 
enable the tree to build using compilers that do not ignore this incorrect 
command line switch, such as the Intel C compiler. I have Intel's attention at 
the moment, so if we can get the tree 'clean' with respect to their compiler, 
we stand more chance of them addressing outstanding issues that we cannot 
resolve on our own - i.e. compiler internal errors that I'm trying to track 
down. The less modifications Intel have to make to the source tree to get it to 
compiler, the more likely they are to help us ... You get the idea ...

Comment 4

[Alec Flett]

Comment on attachment 124375 [details] [diff] [review]
Win32 compiler/linker option correction

seawood needs to review this.. sonds like the right thing though.

Comment 5

[hacker formerly known as [e-mail]]

Comment on attachment 124375 [details] [diff] [review]
Win32 compiler/linker option correction

You need a win32 developer to review this.

Comment 6

[Steve Williams]

Would be nice to get this into 1.4, but not essential.

Do I need to do anything else to get this moving along ?

Comment 7

[Steve Williams]

Adam - can you review this, please.

Comment 8

[Adam Lock]

Comment on attachment 124375 [details] [diff] [review]
Win32 compiler/linker option correction

r=adamlock

Comment 9

[(default assignee for unassigned bugs. does not receive bugmail)]

Mass reassign of Build/Config bugs to Leaf.

Comment 10

[Stephen Walker]

leaf, can you checkin steve's patch?

Comment 11

[Benjamin Smedberg]

got moa=bryner on IRC, fixed-on-trunk

Comment 12

[Bernd]

Attachment: patch

there is some strange sign at the end of the line it looks like ctrl-m like
that note sign.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 133386 [details] [diff] [review]
patch

I just checked in this patch to fix the linker bustage bernd was having... this
just removes a stray ^M that was at the end of that line.