207403 - URLs in the js console are not formatted like a link (blue, underlined) anymore

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect, P3)

Description

[Steffen Wilberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030526 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030526 Mozilla Firebird/0.6

URLs in the js console are not formatted like a link.

Reproducible: Always

Steps to Reproduce:
1. Open Javascript console.
2. Look for a link in it. If you can't find one, browse to
http://java.sun.com/getjava/

Actual Results:  
The url in the js console is not formatted like a link, e.g. blue and underlined.


Expected Results:  
The url should be formatted like a link so that you know where to click on (not
on Source File, not on Line #).

Mozilla does this right.

Comment 1

[Erik]

Confirmed using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b)
Gecko/20030529 Mozilla Firebird/0.6

=> change status to "New" since I didn't find a related, already existing bug

Note: I don't get a JS error when visiting java.cun.com - perhaps one has to use
a different page...

Comment 2

[Karl Guertin]

Problem still exists in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b)
Gecko/20030726 Mozilla Firebird/0.6.1

Use http://www.javascriptkit.com/javatutors/errortest.htm for testing, which
should remain permanently erroneous.

Comment 3

[Scot Hale]

I am experencing this bug with FireFox 0.8 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Comment 4

[Chris Neale]

chrome://global/content/console.xul needs to reference
chrome://commmunicator/skin/formatting.css - then all will be well : )

Comment 5

[Steffen Wilberg]

Thanks for the tip. But we're not using
chrome://commmunicator/skin/formatting.css anywhere in Firefox, so I'd suggest
to add the rules we need to console/skin/console.css.

Comment 6

[Steffen Wilberg]

Attachment: patch: add rules to console/skin/console.css

I've left out some rules that don't work:
.text-link:focus { color:red }
.text-link:hover:active { color: red }
.text-link[visited="true"] { color: purple }

Comment 7

[Pierre Chanial]

marking fixed.
I just saw that there was a patch in here. Some time wasted.
I put the rules in the toolkit formatting.css file. class text-link can be useful. 

Comment 8

[Steffen Wilberg]

Comment on attachment 144317 [details] [diff] [review]
patch: add rules to console/skin/console.css

Fixed by pch.

Comment 9

[José Jeria]

Attachment: Screenshot of regression

Did this patch cause the link in the page info blue and the context menu to it
underlined?

Comment 10

[Steffen Wilberg]

(In reply to comment #9)
> Did this patch cause the link in the page info blue and the context menu to it
> underlined?
Yes and no. It wasn't my patch, but pch's checkin for this bug:
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=03%2F20%2F2004+00%3A01&maxdate=03%2F20%2F2004+00%3A01
See bug 238186.

Comment 11

[Steffen Wilberg]

Broken again with the new Winstripe theme. -> Reopening, at least for Windows.

Comment 12

[Steffen Wilberg]

Attachment: fix it again

pch said in comment 7:
"I put the rules in the toolkit formatting.css file. class text-link can be
useful."
This patch puts them back there. It has no effect to page info (bug 238186).

Another option is to put these in toolkit/themes/winstripe/global/console.css,
but I agree with pch that these rules can be useful.

Comment 13

[Steffen Wilberg]

Comment on attachment 150378 [details] [diff] [review]
fix it again

Mike, this is a regression fix for 0.9.

Comment 14

[Steffen Wilberg]

patch ready.

Comment 15

[Mike Connor [:mconnor]]

Comment on attachment 150378 [details] [diff] [review]
fix it again

blech, this old chestnut? :)

Comment 16

[Steffen Wilberg]

-> js console.

Comment 17

[Steffen Wilberg]

Missed 0.9.

Comment 18

[Blake Ross]

Not blocking 1.0, but feel free to check this in.

Comment 19

[Mike Connor [:mconnor]]

fixed branch and trunk

Comment 20

[Steffen Wilberg]

Note:
mozilla/toolkit/themes/pinstripe/global/formatting.css and
mozilla/toolkit/themes/qute/global/formatting.css already contain these css
rules on branch and trunk.