207481 - [FIX]id attribute outside a form overrides

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Joerg Baumann]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030401
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030401

an image with id="reset" outside a form overrides the reset() function in the
Javascript representation of the form-element.

Reproducible: Always

Steps to Reproduce:
1. load testcase strict.html or transitional.html
2. enter text
3. click on "Reset me"

Actual Results:  
entered text is still there

Expected Results:  
entered text should be erased

I tested it with mozilla 1.0.1, 1.2.1, 1.3 1.4a, 1.4b on linux. All show the
same behavior.

There are three examples
1. strict.html (uses HTML 4.01 Strict and id attribute)
2. transitional.html (uses HTML 4.01 Transitional and name attribute)
3. xhtml.xml (uses XHTML 1.0 Strict and id attribute)

All are very similar and use following construct:

<img ... id/name="reset">
...
<form ... id/name="formular">
</form>

Case 3 works, but for case 1 and 2 the image overrides the reset()-function of
the formular which is then not longer accessbile from javascript.

So it's seems that the HTML DOM is broken here, but the XHTML DOM works.

Comment 1

[Joerg Baumann]

Attachment: strict.html

broken example

Comment 2

[Joerg Baumann]

Attachment: transitional.html

broken example

Comment 3

[Joerg Baumann]

Attachment: xhtml.xml

working example

Comment 4

[Alfonso Martinez]

this is the same problem that bug 148782, but I can't find an open bug about the
"reset" problem.

Comment 5

[Fabian Guisset]

Wups sorry I added myself as CC and pressed enter stupidly.
This bug should be easy to fix now that bug 148782 is fixed. The mechanisms are
there, just have to use them.
Marking NEW. P2/Normal to match bug 148782. All/All, adding testcase keyword.

Comment 6

[Hixie (not reading bugmail)]

brendan? What's going on here?

Comment 7

[Brendan Eich [:brendan]]

What a mess.  Cc'ing bz, who fixed bug 148782.  I don't know the code involved
here, and don't have time to analyze it.  I expect jst or peterv can help too.

/be

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

We suck.  Should have noticed the lack of an aForm check here... :(

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 138468 [details] [diff] [review]
Patch

jst, would you do the honors?

Comment 10

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 138468 [details] [diff] [review]
Patch

r+sr=jst

Comment 12

[Boris Zbarsky [:bzbarsky]]

Fix checked in for 1.7a