207713 - Mozilla needs support for moz specific file extension icons

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Sean Su]

There isn't a way to specify mozilla icons for file types that it can handle. 
For example, mozilla sets itself to be the default handler for:
  .html
  .htm
  .xul
  .shmtl
  .jpeg
  .gif
  etc...

But there isn't a way for mozilla to assiciate unique moz icons for each of the
file types.  Right now, it's defaulted to using the icon in mozilla.exe for all
file types.

( This is a place holder for bugscape bug
http://bugscape.mcom.com/show_bug.cgi?id=4819 )

Comment 1

[Sean Su]

Attachment: patch v1.1

Comment 2

[Sean Su]

Comment on attachment 124615 [details] [diff] [review]
patch v1.1

got r=sgehani and sr=jag
seeking a=

Risk: minimal.	risk is localized to a small part of win32 specific code.  If
anything goes wrong (like missing icons, or path problems) it'll simply default
to what it did before which is to use the icon from mozilla.exe (or the main
browser app).

Path has been tested with mozilla.exe under win2k.

Comment 3

[Sean Su]

Attachment: patch v1.2

This patch has an additional call to SHChangeNotify() after assiciations have
changed (compared to patch v1.1).

It turns out that a call to SHChangeNotify() is necessary in order for the file
association icons to be updated, else the user will still see the previous
association icon until at least the system rebooted, even though it'll bring up
the new app associated with the file type.

Here is something that I just ran into while debugging this bug.  There's a
feature introduced for WinXP and Win2k that allows the user to override global
file associations.  This means that if the user had manually set the
association for .html, Mozilla's resetting will not handle this override.  The
global associations will have changed to refer to Mozilla, but it will still
use the app referenced in the override.

Turns out that IE does not handle this override either.

I'll be talking to others to see what the best approach to this user override
feature should be (perhaps do nothing).

Comment 4

[Sean Su]

Attachment: patch v1.3

added call to SHChangeVerify() to the uninstall code.

Comment 5

[Sean Su]

Comment on attachment 124707 [details] [diff] [review]
patch v1.3

seeking r=,sr=.

I'm also getting an optimized build going with the patch to make sure that the
call to SHChangeNotify() does not cause problems under win95.

Comment 6

[Paul Wyskoczka]

adt:  nsbeta1+/adt2

Comment 7

[Sean Su]

Attachment: patch v1.4

This patch now uses image-file.ico for image file types (.jpg, .png, .bmp,
etc...) and doc-file.ico for document types (.html, .xml, .xul, etc...).

Mozilla doesn't have these files yet, but the code will be in place for when we
have the image files.

Comment 8

[Grace Bush]

test build on win95 worked as expected

Comment 9

[jag (Peter Annema)]

Comment on attachment 124772 [details] [diff] [review]
patch v1.4

sr=jag

Comment 10

[Sean Su]

Comment on attachment 124772 [details] [diff] [review]
patch v1.4

re-seeking a=
tested under winXP, win98, win95 (mozilla.exe).  all works as expected.
risk is low.  affected code is localized to win32 platforms and also to the
file type association changes.

Comment 11

[Rafael Ebron (:rebron)]

a=adt.  Please land this fix on the Mozilla 1.4 branch and add fixed1.4 to the
staus whiteboard.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 124772 [details] [diff] [review]
patch v1.4

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 13

[(not reading, please use [e-mail] instead)]

noting a=asa,sspitzer for 1.4 final

Comment 14

[Sean Su]

patch checked in to trunk and branch.

Comment 15

[Grace Bush]

verified on branch 2003060405

Comment 16

[Grace Bush]

verified on trunk 2003060504

Comment 17

[Peter Lairo]

Using: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b) Gecko/20030609

I just tested this for JPG and get the red dino head icon (see attachment). I
thought it would (should) be more like the greyrest icons for documents (see
attachment). Reopen? Apologies if I'm just confused.

Reproduce: Edit | Preferences | Advanced | System -> Select "JPEG".

Comment 18

[Peter Lairo]

Attachment: What I get when I select: Edit | Preferences | Advanced | System -> Select "JPEG".

Comment 19

[Peter Lairo]

Attachment: What I SHOULD(?) get when I select: Edit | Preferences | Advanced | System -> Select "JPEG".