2077656 - Last upload folder paths not being remembered in specific websites (all sharing the same upload folder path), then defaulting to the downloads folder after saving a file in there, in Firefox 157.0

Status: NEW

(Firefox :: Untriaged, defect, P2)

Description

[Fleur [:Fleur]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:157.0) Gecko/20100101 Firefox/157.0

Steps to reproduce

• Open a new Firefox session.
• Go to any website where you can upload a file (generally a picture/image file) to share it, the path is supposedly the last one used to upload something for there.
• Download a file (ie right click, "save image as"), saving it in the downloads folder (ie. Downloads, being my default folder).

Actual results

• As I upload a new file in a website, the last upload folder path is redirected to the Downloads folder. A few clicks here and there, I choose another folder (ie. from "Documents"), and the file uploads, fine.
• I then upload a new file, and the last upload folder is redirected to the Downloads folder, again.
• Closing the browser, resets this behavior, but once you download a new file, the upload path is changed to the Downloads folder, once again.

Expected results

The upload folder path should be the last folder that Firefox remembers from the website I am uploading the file for (or websites, as I found out that, right now at this moment in Firefox 157.0, it's the same last folder path for every website I have used before; it doesn't matter which one I have used, it's the same upload path), not my Downloads folder.

The paths from upload files shouldn't be crashing/colliding with the downloads folder path (unless I am uploading a file from the Downloads folder) as I download a new file (saved there or in any other folder), nor should be defaulting to it after I am uploading a file from anywhere else. I previously tested this as well in another profile, and the behavior remains the same.

My observation is that this might be something provoked in Firefox 157.0, since the previous Firefox version (156.0.1, I believe?) wasn't behaving like this.

Comment 1

[[e-mail]]

Similar case here:

I have the following settings:

• "Ask where to save files before downloading" checked in the Settings
• browser.download.lastDir.savePerSite set to false because I want Firefox to always use the last used directory independent of the site
• Firefox behavior for type PDF is set to "Open in Firefox"

Whenever I view a PDF in Firefox and then download it by Ctrl+S, using the download button in the toolbar or choosing "Save as" from the rightclick menu, I always get shown the "Downloads" directory in the file picker instead of the last location where I saved my last (PDF) file.

Weirdly I think with other file types or perhaps files which are not first shown in the Firefox preview, the previously used directory IS shown in the filepicker.

This is extremely annoying and a new bug, this definitely worked fine before (not sure which version change did cause this change but it seems to have started to fail just recently)

Comment 2

[Cameron]

Yep, same thing here.

I noticed the setting browser.download.lastDir.savePerSite was removed as well in 157. Adding it back in didn't bring this functionality back though unfortunately.

Comment 3

[Ghot]

Win 11 26300.9550 and Firefox 157.0 and 157.0.1

If I export my bookmarks to some location, in my case F:\Bookmarks\bookmarks.html ...the next time I try to upload an image to a website, instead of looking for the image on my desktop, it looks for the image in F:\Bookmarks.
Restarting Firefox and then "browsing" to my desktop clears the issue, until I export my bookmarks once again.

Then I have to restart and browse to my desktop once again.

I think what's needed is something in Settings like what we have for download location, where we could choose a default location to upload from.

Comment 4

[Radu Serban]

I am experiencing the same issue with Firefox 157.0 on Windows 11 when uploading photos to https://www.kleinanzeigen.de.

Steps to reproduce:

Open the photo upload dialog while creating or editing an advertisement.

Navigate to the folder containing my photos.

Select and upload a photo.

Open the photo upload dialog again.

Actual result:
Firefox does not remember the folder used for the previous photo upload. I have to navigate to my photo folder again.

Expected result:
The upload dialog should reopen in the last folder used for uploading photos.

This affects my regular workflow because I frequently upload multiple watch photos for advertisements.

Comment 5

[gotmilk0112]

Yeah, I'm getting a similar bug. Any time I bring up the dialog to upload a file, it always defaults to the last folder that I saved a file to.

It used to remember the last folder I picked an upload from, but now it just keeps defaulting to opening the dialog at the location of the last saved file, regardless of website.

Comment 6

[Marco Bonardo [:mak]]

I've seen similar reports on Reddit. Looking at the 157 changes, the only one I found that touches how the file picker chooses its starting folder is bug 2068406.

If <input type=file> code runs in the content process (via nsFilePickerProxy). If the content sandbox can't stat the remembered upload folder, no display directory is sent to the parent. On Windows the picker then falls back to the process-wide last-used folder, which save dialogs also update (downloads, bookmarks export). That would match the reports here.
This is only a hypothesis, I haven't verified it.

Comment 7

[Edgar Chen [:edgar]]

I can reproduce this. And yes, this is a regression of bug 2068406. :(

STR:

1. Load https://developer.mozilla.org/en-US/play?id=mlq7LZqGYAaRLlqX78awQOmlutfqdYpGgmzuiSbOE9LfLNr5baAIU2CyfGWCOzYTfsJQ82BsLLh9IdaM
2. Right click on image to open context menu and click "Save Image As ...".
3. Save image to Download folder.
4. Click input file to open file picker, select a file under Document folder.
5. Click input file again.

Expected Result:
The file picker should open to the path of the last folder selected by the user.

Actual Result:
The file picker opens to the Downloads folder.

Comment 8

[Edgar Chen [:edgar]]

Attachment: Bug 2077656 - Don't check whether directory is readable in content process; r?smaug

Comment 9

[Pranav Rai]

Facing the same issue. The upload file picker defaults to whatever folder I last saved a file in across all sites. If I last saved a file in Folder A, it will show Folder A as input when I click upload for all sites. Then if I save a file in Folder B, it will start showing Folder B as when I try to upload files. Quite an annoying issue that I noticed from today.