207949 - Show Chatzilla as installable extension in Firebird GUI/FE

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[Karsten Düsterloh]

Chatzilla does work with Firebird 
(at least since 0.6:
- install a xpi from http://www.hacksrus.com/~ginda/chatzilla/ 
- type "irc:" into the URL bar
), but isn't visible neither in the "Extensions-Options" nor elsewhere in the
browser GUI.
This should be changed to let CZ be used by "Joe User".

[I was quite unsure if this RFE shouldn't be filed against the Phoenix
component, but the changes would be CZ changes, I guess, so here it is...]

Comment 1

[Jens Bannmann]

This will require additional changes, as Chatzilla's pref panels no longer work
in Firebird - e.g. preference settings are not loaded/saved. However, I managed
to get it working for MozGest in a backward-compatible way so that no separate
packages for Seamonkey and Firebird are needed. As soon as I have time, I will
try hacking something similar for Chatzilla.

Note: CZ will have its own settings window in Firebird. Since we no longer have
a "panel-tree" as in Seamonkey, I'd recommend using tabpanels - if rginda
agrees. This would look a bit like the recent mozgest nightlies.

Comment 2

[James Ross]

Someone suggested having a button (i.e. like the other toolbar buttons that you
can customise) to start ChatZilla - that should be relatively easy. Also, making
it show up as a Firebird "extension" looks really easy (few changes to
contents.rdf). Doing something with the "Settings" button in Firebird will have
to wait until we've got the new prefs done.

Jens, I think (last I heard, though it was a while back now) was rginda was
going (or get someone else ;) ) to do a special webpage-like thing for the
prefs, so it may not be worth your effort. :)

Comment 3

[James Ross]

Attachment: Updates contents.rdf.in for Firebird/extension

Adds URL and description (feel free to rewrite, I made it up on the spot) for
ChatZilla, along with the extension setting to make it show up in Firebird's
extension list. No settingsURL yet, nothing to point it at. :)

Comment 4

[Robert Ginda]

Comment on attachment 135572 [details] [diff] [review]
Updates contents.rdf.in for Firebird/extension

This doesn't break anything in seamonkey, right?

If not, r=rginda

Comment 5

[James Ross]

I will try it with my own nightly builds tonight, but I'm pretty sure (99%)
it'll be fine.

Comment 6

[James Ross]

Yup, works fine in Mozilla, and correctly shows up in Firebird. :)

Comment 7

[James Ross]

Checked in.

Comment 8

[alanjstr]

This does not include a button, correct?  How about a menu item under Tools?  I
don't see either in the patch.  I would not consider this bug resolved until
some method of launching CZ (other than typing in a URL or clicking one) is
available.   This patch just adds an item to the options->extensions panel. 

Chatzilla has preferences, doesn't it?  So why no settingsURL?  Or shall that be
a seperate bug?

Comment 9

[James Ross]

Appologies, this only fixed it appearing in the list. Reopening.

The settingsURL has been left out because there is nothing available for it to
point to at the moment, since the old Mozilla prefs pages don't work any more. I
think there's a seperate bug about that.

Comment 10

[James Ross]

Working on this, assinging to me.

Comment 11

[James Ross]

Ok, I've got a working, skined, localisable button on my toolbar. I had to hack
a *lot* of bits of Firebird to get it to work, since I wasn't building from
clean (and it's ability to notice changes is... well, very bad). I will run a
clean build tonight, and hopefully (i.e. if it works) tomorrow I'll attach the
patch.

If someone can enlighten me on the enable/disable extension stuff (like, do we
need any code for it or is it entirely handled by Firebird?) I'd be most greatful.

Comment 12

[Jens Bannmann]

James: The enabling/disabling is entirely handled by firebird. When an extension
is disabled, none of its overlays will be loaded. So AFAIK, no work should be
needed by Chatzilla's XUL and scripts.

However, the XPCOM JS Component (for irc url handling IIRC) might be an
exception - someone has to find out whether disabling the extension will disable
it as well, and if not, how the component should be modified to detect whether
chatzilla was disabled.

Comment 13

[James Ross]

Jens, thanks for the clarification. It does correctly "remove" the button when I
disable Chatzilla, but as you suspected the irc: URL handler is still in place,
and still opens Chatzilla for irc: URLs. I will look into this, but won't hold
up the button patch for it.

Comment 14

[Jens Bannmann]

If you are able to access the main browser window from the url handler, you
could just check whether your button exists (even if it's not on the toolbar,
it's in the DOM IIRC). An alternative might be to access the chrome registry and
check whether the node "urn:mozilla:package:chatzilla" has a property named
"disabled". No idea whether there's a better way.

Comment 15

[James Ross]

Wow, my little RDF code worked. :)  (impossible to debug, though)
It appears to even enable without a restart, though disabling doesn't.

Will attach a priliminary patch for enabling and disabling the irc: code.

Comment 16

[James Ross]

Attachment: diff -u of chatzilla-service.js.

This patch adds a small section of RDF code to check for the disabled node in
the chatzilla package.

Comment 17

[Jens Bannmann]

Why "impossible to debug"?

Looks good, even if the following code looks irritating and would certainly
never work in C++ or Java:

try {
  (...)
  var rv = rdfDS.GetTarget(resSelf, resDisabled, true);
  (...)
}
if (rv) // one would expect rv didn't exist anymore in this line

Seems JavaScript doesn't care where a variable was declared... is the above
coding considered bad style?

Btw, did you insert a menu item for Chatzilla, as requested in comment #8?

Comment 18

[James Ross]

You're right about the scoping... I /assume/ JS doesn't create a new scope for
try/catch, since it worked. :)  I'm happy to make the code neater/better, I was
just having a hard time debugging it (had to use Mozilla, and dump()s, two of
which are still there).

This doesn't add a menu, it's just the irc: URL code. I've left off adding a
menu for now, because I can't think of a decent place for it to go. The tools
menu seems to be the common place, but I've already seen one extension add an
item to there *below* the "Options..." item, which looks bad. Do the Firebird
devs have any recommended place to add menu items?

Comment 19

[James Ross]

Attachment: diff to add CZ button (includes 3 new files)

The three new files have be licensed according to the docs on mozilla.org, if
this is not correct, I'll correct them.

This patch adds a button that can be customised onto the Firebird toolbar, and
uses the "cZ" icon found in the Window menu in Mozilla.

Comment 20

[James Ross]

Attachment: Updated diff of chatzilla-service.js

Addresses the odd-looking scoping and removes the dump()s.

Comment 21

[Robert Ginda]

Comment on attachment 136704 [details] [diff] [review]
Updated diff of chatzilla-service.js

r=rginda

Comment 22

[James Ross]

Comment on attachment 136704 [details] [diff] [review]
Updated diff of chatzilla-service.js

Makes the irc: handler behave correct with respect to disabling the Chatzilla
extension.

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 136704 [details] [diff] [review]
Updated diff of chatzilla-service.js

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 24

[Francisco Cipriano]

ChatZilla can be launched through the bookmarks toolbar, using Firebird 0.7. To
do  this, go to Bookmarks> Manage Bookmarks> Bookmarks Toolbar folder> New
Bookmark> Name: "ChatZilla (or whatever you want)", Location: "irc:".  To use,
just press th e ChatZilla bookmark; of course, you'll end up with a blank page,
but that's fine for me. Now just add an icon to make it look pretty:)

Comment 25

[James Ross]

Comment on attachment 136537 [details] [diff] [review]
diff to add CZ button (includes 3 new files)

Verbal r=rginda given on IRC yesterday.

Comment 26

[James Ross]

Comment on attachment 136537 [details] [diff] [review]
diff to add CZ button (includes 3 new files)

This is the last part of this bug, and gives a UI to start CZ from Firebird.

Comment 27

[Asa Dotzler [:asa]]

Comment on attachment 136537 [details] [diff] [review]
diff to add CZ button (includes 3 new files)

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 28

[James Ross]

Checked in the final part (the button), and is available as 0.9.51 from
http://www.hacksrus.com/~ginda/chatzilla/.

Comment 29

[Chris Neale]

attachment 136537 [details] [diff] [review] has two bits missing afaict

class="toolbarbutton-1" and a suitable label

after all, some people have text only

Comment 30

[James Ross]

The label's easily fixed, but I'd like an explanation for having a class name
for a toolbarbutton on a toolbar.

Comment 31

[James Ross]

Attachment: Added label and class to button

This uses the same string for the tooltip text and the label. I found all the
class name did was put the text under the image when you have both turned on.
Pretty silly, but it's in the patch anyway (the button doesn't have anywhere
*nearly* enough spacing between the image and the text, with or without the
class name, but that's Firebird's fault).

Comment 32

[James Ross]

Comment on attachment 136935 [details] [diff] [review]
Added label and class to button

Cosmetic fix for showing text in "text and image" and "text only" toolbar
modes.

Comment 33

[Brendan Eich [:brendan]]

Comment on attachment 136935 [details] [diff] [review]
Added label and class to button

Go fast for 1.6b.

/be

Comment 34

[James Ross]

Checked in.