207999 - Cannot derive from EcmaError class since construction parameter is private class

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Roland Knight]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier: 

We need to derive from the EcmaError class to create our own exceptions. The 
first parameter of the EcmaError constructor is the private class NativeError. 
Either the NativeError class needs to be made public or the parameter changed 
to a public class.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Igor Bukanov]

Attachment: Fix: use generic Scriptable as an argument to EcmaError

The only reason for EcmaError to require NativeError as constructor argument is
to be able to call getName/getMessage on the error object. But NativeError
objects will return the same information via generic
ScriptRuntime.getStrIdElem(object, "name"/"value"), so the patch uses that
method instead. 

It is now a responsibility of EcmaError caller to supply objects with
reasonable 
values for "name"/"message" properties.

Comment 2

[Igor Bukanov]

I committed the fix

Comment 3

[Phil Schwartau]

Rubber-stamp vrfy -

Comment 4

[Igor Bukanov]

Targeting as resolved against 1.5R5