208265 - Accessibility can crash after profile manager closes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Aaron Leventhal]

If accessibility is active and the profile manager is run, there can be a crash
after the window closes.

This seems to happen when we do:
    nsCOMPtr<nsICommandManager> commandManager = do_GetInterface(container);

on the for the XUL window's docshell.

Comment 1

[Aaron Leventhal]

Attachment: Only checks the command manager for content docs. Also moves timer shutdown to more appropriate place, symmetrical to where the timers are created.

Comment 2

[Kyle Yuan]

Comment on attachment 124900 [details] [diff] [review]
Only checks the command manager for content docs. Also moves timer shutdown to more appropriate place, symmetrical to where the timers are created.

r=kyle

Comment 3

[Alec Flett]

Comment on attachment 124900 [details] [diff] [review]
Only checks the command manager for content docs. Also moves timer shutdown to more appropriate place, symmetrical to where the timers are created.

sr=alecf

Comment 4

[Aaron Leventhal]

checked in

Comment 5

[Kyle Yuan]

Comment on attachment 124900 [details] [diff] [review]
Only checks the command manager for content docs. Also moves timer shutdown to more appropriate place, symmetrical to where the timers are created.

For making the accessibility feature work better and more stable in 1.4.x, we
need to get this patch in. This fix has been in trunk for a long period. It
won't affect other modules.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 124900 [details] [diff] [review]
Only checks the command manager for content docs. Also moves timer shutdown to more appropriate place, symmetrical to where the timers are created.

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?

Comment 7

[Kyle Yuan]

Asa, sure, we can wait for 1.4.2.